Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brand: presentation theme: presenter photo should not be hard-coded #26878

Closed
bcmills opened this issue Aug 8, 2018 · 5 comments
Closed

brand: presentation theme: presenter photo should not be hard-coded #26878

bcmills opened this issue Aug 8, 2018 · 5 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@bcmills
Copy link
Contributor

bcmills commented Aug 8, 2018

I'm trying to use the Go presentation theme in a new presentation.

In the first slide, there is a presenter photo example (of @cassandraoid with a plush Gopher): https://golang.org/s/presentation-theme#slide=id.g33148270ac_0_143

That specific photo is currently embedded in the “Theme” layer, but it should not be: individual presenters (other than @cassandraoid herself) should always replace it with their own photo.

@bcmills bcmills added this to the Unreleased milestone Aug 8, 2018
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Aug 8, 2018
@bcmills bcmills changed the title brand: presenter photo should not be hard-coded in presentation theme brand: presentation theme: presenter photo should not be hard-coded Aug 8, 2018
@cassandraoid
Copy link

cassandraoid commented Aug 8, 2018 via email

@agnivade
Copy link
Contributor

agnivade commented Aug 9, 2018

Nice hack. Unfortunately, not everyone wants to put up their own photo (or maybe its just me 😆 ).

I was trying to make a deck too, and unfortunately had to use a different slide altogether, because there was no way to remove the photo. Would like it to be changeable.

@bcmills
Copy link
Contributor Author

bcmills commented Aug 9, 2018

@agnivade, once you've copied the theme to a new document you can customize it however you like. (I've been doing that to address a lot of these issues in my slides.)

The menu option to do it is not particularly discoverable, unfortunately.

screenshot 2018-08-09 at 09 57 09

@agnivade
Copy link
Contributor

agnivade commented Aug 9, 2018

Ah you can edit master ! Amazing. It felt so debilitating not to be able to edit a lot of preset settings. Thanks for the pointer. (I completely missed this option too)

@rsc rsc unassigned spf13 Jun 23, 2022
@eliben
Copy link
Member

eliben commented Oct 31, 2023

I believe this has been fixed now. The presentation template linked from https://go.dev/s/presentation-theme no longer includes a hard-coded photo.

@eliben eliben closed this as completed Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

5 participants