New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/go: unavailable vcs fails test #26837
Labels
FrozenDueToAge
NeedsFix
The path to resolution is known, but the work has not been done.
Testing
An issue that has been verified to require only test changes, not just a test failure.
Milestone
Comments
Change https://golang.org/cl/128195 mentions this issue: |
bcmills
added
the
NeedsFix
The path to resolution is known, but the work has not been done.
label
Aug 9, 2018
bcmills
added
the
Testing
An issue that has been verified to require only test changes, not just a test failure.
label
Aug 9, 2018
Assigned to @iwdgo, since a fix is pending in https://golang.org/cl/128195. |
Issue can be closed as https://golang.org/cl/207700 moved relevant tests to scripts which include do not fail when VCS command is unavailable.
|
Thanks for pointing this out. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
FrozenDueToAge
NeedsFix
The path to resolution is known, but the work has not been done.
Testing
An issue that has been verified to require only test changes, not just a test failure.
Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (
go version
)?go version go1.11beta3 windows/amd64
Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (
go env
)? YesWhat did you do?
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
What did you expect to see?
What did you see instead?
The test fails as one vcs (Mercurial in the example) is unavailable. Test should be skipped with the usual warning when vcs is unavailable. As a side remark, cmd/go tests are timing out after 10 minutes. As tests run in parallel as 'PAUSED" until all tests are listed as per output above, such errors never appear in short mode.
The text was updated successfully, but these errors were encountered: