Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/x509: parse trust settings in root_nocgo_darwin #26830

Closed
FiloSottile opened this issue Aug 6, 2018 · 1 comment
Closed

crypto/x509: parse trust settings in root_nocgo_darwin #26830

FiloSottile opened this issue Aug 6, 2018 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Darwin
Milestone
Unplanned

Comments

@FiloSottile
Copy link
Contributor

#24652 addressed a number of issues with root_[no]cgo_darwin, but the nocgo version still resorts to shelling out to security instead of parsing the trust settings.

Ideally, we want to obtain the trust settings from security, and apply the same logic as the cgo code. (Possibly the same code, so we don't make mistakes twice.)
@FiloSottile FiloSottile added the NeedsFix The path to resolution is known, but the work has not been done. label Aug 6, 2018
@FiloSottile FiloSottile added this to the Unplanned milestone Aug 6, 2018
@FiloSottile
Copy link
Contributor Author

Let's do #32604 instead.

@golang golang locked and limited conversation to collaborators Apr 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Darwin
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
2 participants
@FiloSottile @gopherbot