Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: mod tidy panics when there's no Go files but a go.mod #26808

Closed
vrischmann opened this issue Aug 4, 2018 · 2 comments
Closed

cmd/go: mod tidy panics when there's no Go files but a go.mod #26808

vrischmann opened this issue Aug 4, 2018 · 2 comments
Labels
FrozenDueToAge modules NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.12

Comments

@vrischmann
Copy link

What version of Go are you using (go version)?

go version devel +65fa2b615b Fri Aug 3 23:35:53 2018 +0000 linux/amd64

Does this issue reproduce with the latest release?

No (but does using Go 1.11beta3)

What operating system and processor architecture are you using (go env)?

Linux amd64

What did you do?

While playing around with Docker trying to build a cache layer from Go modules I found a case where go mod tidy panics.
At that point there were no Go files, only go.mod and go.sum.

Turns out it is easily reproducible: in an empty directory, adding only a go.mod file with module foo.bar is sufficient to trigger the panic.
This is of course not a valid use case but I don't think the command should panic.

What did you expect to see?

Not a panic.

What did you see instead?

panic: runtime error: slice bounds out of range
goroutine 1 [running]:
cmd/go/internal/modload.(*mvsReqs).required(0xc00024b030, 0xc000270c26, 0x7, 0x0, 0x0, 0xc00012b4f8, 0x40f639, 0x8e4980, 0xc00027fba8, 0xc00012b598)
        /usr/local/go/src/cmd/go/internal/modload/load.go:794 +0x1232
cmd/go/internal/modload.(*mvsReqs).Required.func1(0xc0001e1524, 0x90fd00)
        /usr/local/go/src/cmd/go/internal/modload/load.go:724 +0x83
cmd/go/internal/par.(*Cache).Do(0xc00024b048, 0x90fd00, 0xc0001e1500, 0xc00012b708, 0xc00012b8d0, 0xc00012b810)
        /usr/local/go/src/cmd/go/internal/par/work.go:128 +0xd6
cmd/go/internal/modload.(*mvsReqs).Required(0xc00024b030, 0xc000270c26, 0x7, 0x0, 0x0, 0xc00024b030, 0x70, 0x68, 0x9218e0, 0x0)
        /usr/local/go/src/cmd/go/internal/modload/load.go:723 +0x10f
cmd/go/internal/modcmd.modTidyGoSum.func1(0xc000270c26, 0x7, 0x0, 0x0)
        /usr/local/go/src/cmd/go/internal/modcmd/tidy.go:80 +0x10b
cmd/go/internal/modcmd.modTidyGoSum()
        /usr/local/go/src/cmd/go/internal/modcmd/tidy.go:87 +0x164
cmd/go/internal/modcmd.runTidy(0xd4eda0, 0xc0000a6080, 0x0, 0x0)
        /usr/local/go/src/cmd/go/internal/modcmd/tidy.go:66 +0x513
main.main()
        /usr/local/go/src/cmd/go/main.go:218 +0x7d4
@ALTree ALTree added modules NeedsFix The path to resolution is known, but the work has not been done. labels Aug 4, 2018
@gopherbot
Copy link

Change https://golang.org/cl/127778 mentions this issue: cmd/go: fix panic when go mod tidy an project with no Go file

@ianlancetaylor ianlancetaylor added this to the Go1.12 milestone Aug 5, 2018
@agnivade agnivade mentioned this issue Aug 18, 2018
Closed
@agnivade
Copy link
Contributor

Fixed by https://go-review.googlesource.com/c/go/+/129799.

@golang golang locked and limited conversation to collaborators Aug 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge modules NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.12
Development

No branches or pull requests
5 participants
@agnivade @vrischmann @ianlancetaylor @ALTree @gopherbot