-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build: stop testing dev.boringcrypto branch on so many builders #26791
Comments
Probably in cmd/coordinator's skipBranchForBuilder and/or x/build/dashboard/builders.go. |
I suggest testing it on at least one other builder, because the fallbacks are supposed to keep working. |
Testing on at least one other builder in addition to Some possibilities:
|
If we need to pick another non-linux/amd64 builder, at least pick a GCE-based one where we have lots of capacity. So not Darwin, and not arm. windows/386 gets a different GOOS and a different GOARCH with one new builder. Or freebsd/386, but freebsd and linux might be too similar. |
Change https://golang.org/cl/149606 mentions this issue: |
Sounds like the decision is to use |
Change https://golang.org/cl/149739 mentions this issue: |
Change https://golang.org/cl/149738 mentions this issue: |
This change takes care of a TODO comment. It makes the builder configuration more centralized and contained in the dashboard package. Invert it for consistency with BuildConfig.BuildRepo method. Updates golang/go#26791 Change-Id: I46368adadb85f2ec730da4fc0abe5fd6a112a7c7 Reviewed-on: https://go-review.googlesource.com/c/149738 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
We really only care about testing the dev.boringcrypto branch on linux/amd64, really. Right now we're testing it on everything.
The text was updated successfully, but these errors were encountered: