Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: cgo test broke linux-amd64-nocgo build #26758

Closed
bradfitz opened this issue Aug 2, 2018 · 3 comments
Closed

cmd/go: cgo test broke linux-amd64-nocgo build #26758

bradfitz opened this issue Aug 2, 2018 · 3 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.11

Comments

@bradfitz
Copy link
Contributor

bradfitz commented Aug 2, 2018

The nocgo builder is broken as of https://go-review.googlesource.com/c/go/+/127297:

https://build.golang.org/log/9bced174cbb8cb8a6eeeca45926976b8989cb148

--- FAIL: TestScript (0.00s)
    --- FAIL: TestScript/mod_case_cgo (0.03s)
        script_test.go:150: 
            > env GO111MODULE=on
            > go get rsc.io/CGO
            [stderr]
            go: finding rsc.io/CGO v1.0.0
            go: downloading rsc.io/CGO v1.0.0
            can't load package: package rsc.io/CGO: build constraints exclude all Go files in $WORK/gopath/pkg/mod/rsc.io/!c!g!o@v1.0.0
            [exit status 1]
            FAIL: testdata/script/mod_case_cgo.txt:3: unexpected command failure
            
FAIL
FAIL	cmd/go	110.278s

Should be easy fix to exclude that test when cgo isn't available.
@bradfitz bradfitz added NeedsFix The path to resolution is known, but the work has not been done. release-blocker labels Aug 2, 2018
@bradfitz bradfitz added this to the Go1.11 milestone Aug 2, 2018
@gopherbot
Copy link

Change https://golang.org/cl/127475 mentions this issue: cmd/go: skip cgo test when cgo isn't available

@mpx
Copy link
Contributor

mpx commented Aug 2, 2018

FYI, I'm still seeing failures with this test running all.bash at tip after the fix (b3b2f5d) on a stock Fedora install:

go test proxy starting
go test proxy running at GOPROXY=http://127.0.0.1:37701/mod
go proxy: no archive golang.org/x/text/language 14c0d48
go proxy: no archive golang.org/x/text/language 14c0d48
go proxy: no archive golang.org/x/text/language 14c0d48
go proxy: no archive golang.org/x/text/foo 14c0d48
go proxy: no archive sub.1 v1.0.0
go proxy: no archive badsub.1 v1.0.0
go proxy: no archive versioned.1 v1.0.0
go proxy: no archive versioned.1 v1.1.0
--- FAIL: TestScript (0.00s)
    --- FAIL: TestScript/mod_case_cgo (0.14s)
        script_test.go:150: 
            > [!cgo] skip
            > env GO111MODULE=on
            > go get rsc.io/CGO
            [stderr]
            go: finding rsc.io/CGO v1.0.0
            go: downloading rsc.io/CGO v1.0.0
            # rsc.io/CGO
            ccache: error: Failed to create directory /no-home/.ccache/tmp: Permission denied
            [exit status 2]
            FAIL: testdata/script/mod_case_cgo.txt:5: unexpected command failure
            
FAIL
FAIL	cmd/go	82.643s

Possibly similar to #17668.

@bradfitz
Copy link
Contributor Author

bradfitz commented Aug 2, 2018

@mpx, please file a new bug. This one is closed and yours looks unrelated.

@golang golang locked and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Milestone
Go1.11
Development

No branches or pull requests
4 participants
@bradfitz @mpx @ianlancetaylor @gopherbot