all: use buf.String() instead of string(buf.Bytes()) in tests #26737
Conversation
googlebot
added
the
cla: yes
|
Message from Gerrit User 5150: Patch Set 1: Code-Review-1 Not lgtm sorry. This test is testing the result of Bytes, I don’t want it be reliant on the operation of String when debugging test failures. I think this test is fine as is. Please don’t reply on this GitHub thread. Visit golang.org/cl/127158. |
|
Message from Gerrit User 5065: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/127158. |
|
Message from Gerrit User 5065: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/127158. |
|
Message from Gerrit User 12446: Uploaded patch set 3: New patch set was added with same tree, parent, and commit message as Patch Set 2. Please don’t reply on this GitHub thread. Visit golang.org/cl/127158. |
|
Message from Gerrit User 12446: Uploaded patch set 5: New patch set was added with same tree, parent, and commit message as Patch Set 4. Please don’t reply on this GitHub thread. Visit golang.org/cl/127158. |
as
changed the title
|
Message from Gerrit User 12446: Uploaded patch set 7: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/127158. |
|
Message from Gerrit User 12446: Uploaded patch set 8: New patch set was added with same tree, parent, and commit message as Patch Set 7. Please don’t reply on this GitHub thread. Visit golang.org/cl/127158. |
|
Message from Gerrit User 5065: Patch Set 8: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/127158. |
|
This PR (HEAD: 9395ad8) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/127158 to see it. Tip: You can toggle comments from me using the |
|
Message from Gerrit User 5206: Patch Set 9: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/127158. |
|
Seems like this timed out. |
No description provided.