Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/internal/obj/arm64: legal instruction is rejected by the assembler #26736

Closed
benshi001 opened this issue Aug 1, 2018 · 4 comments
Closed

cmd/internal/obj/arm64: legal instruction is rejected by the assembler #26736

benshi001 opened this issue Aug 1, 2018 · 4 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.12

Comments

@benshi001
Copy link
Member

According to ARM64's manual, "BFI $0, R1, $30, R0" should copy bit 0-29 of R1 to R0, and other bits of R0 are left unchanged.

GCC does the expected operation, but go's arm64 assembler rejects it with error "illegal bit number'".
@benshi001 benshi001 added this to the Go1.11 milestone Aug 1, 2018
@benshi001 benshi001 self-assigned this Aug 1, 2018
@gopherbot
Copy link

Change https://golang.org/cl/127159 mentions this issue: cmd/internal/obj/arm64: fix incorrect rejection of legal instructions

@bradfitz
Copy link
Contributor

bradfitz commented Aug 1, 2018

If this has been broken for several releases now it doesn't need to be in Go 1.11.

@bradfitz bradfitz added the NeedsFix The path to resolution is known, but the work has not been done. label Aug 1, 2018
@bradfitz
Copy link
Contributor

bradfitz commented Aug 1, 2018

@cherrymui, I'll let you decide which release this is for. I don't think this is a regression from Go 1.10? @benshi001, let us know if it is.

@cherrymui
Copy link
Member

cherrymui commented Aug 1, 2018 •
edited

No, it's not a regression. I can reproduce with Go 1.10. So, no need to be Go 1.11 milestone.

As there is a CL, and I think it is very low risk, the CL can go in Go 1.11 as well (also ok if it is not).

@cherrymui cherrymui modified the milestones: Go1.11, Go1.12 Aug 1, 2018
@golang golang locked and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.12
Development

No branches or pull requests
4 participants
@bradfitz @gopherbot @cherrymui @benshi001