Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: TestScript/mod_gobuild_import failing on Plan 9 #26669

Closed
0intro opened this issue Jul 28, 2018 · 1 comment
Closed

cmd/go: TestScript/mod_gobuild_import failing on Plan 9 #26669

0intro opened this issue Jul 28, 2018 · 1 comment
Labels
FrozenDueToAge help wanted OS-Plan9
Milestone
Go1.11

Comments

@0intro
Copy link
Member

0intro commented Jul 28, 2018

CL 125296 added TestScript/mod_gobuild_import. This test is failing on the plan9/386 builder.

--- FAIL: TestScript (0.01s)
    --- FAIL: TestScript/mod_gobuild_import (1.64s)
        script_test.go:146: 
            # go/build's Import should find modules by invoking the go command (1.484s)
            # GO111MODULE=off (0.034s)
            # GO111MODULE=auto in GOPATH/src (0.040s)
            # GO111MODULE=auto outside GOPATH/src (0.020s)
            > cd $GOPATH/other
            $WORK/gopath/other
            > env GO111MODULE=
            > exec $WORK/testimport.exe other/x/y/z/w .
            [stderr]
            2018/07/27 21:50:57 go/build: importGo other/x/y/z/w: exec: "go": executable file not found in $path
            
            [exit status: 'testimport.exe 15094: 1']
            FAIL: testdata/script/mod_gobuild_import.txt:18: unexpected command failure
            
FAIL
FAIL	cmd/go	435.514s

See https://build.golang.org/log/106cd971708626fc4c207db4de8ddc2f3ef4b54e
@0intro 0intro added this to the Go1.11 milestone Jul 28, 2018
@0intro 0intro self-assigned this Jul 28, 2018
@gopherbot
Copy link

Change https://golang.org/cl/126608 mentions this issue: cmd/go: fix TestScript/mod_gobuild_import on Plan 9

jeet-parekh pushed a commit to jeet-parekh/go that referenced this issue Jul 31, 2018
@0intro @jeet-parekh
cmd/go: fix TestScript/mod_gobuild_import on Plan 9
33dc44a 
CL 125296 added TestScript/mod_gobuild_import. This
test is failing on Plan 9, because go/build invokes
the go tool which cannot be found in the path.

The "PATH" environment variable has been updated to
contain the path to the go tool on Unix and Windows,
but on Plan 9, the analogous environment variable is
called "path".

This change fixes the script engine by setting
the "path" environment variable on Plan 9.

Fixes golang#26669.

Change-Id: If1be50e14baceccee591f4f76b7e698f5e12a2d4
Reviewed-on: https://go-review.googlesource.com/126608
Run-TryBot: David du Colombier <0intro@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@golang golang locked and limited conversation to collaborators Jul 29, 2019
@rsc rsc unassigned 0intro Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted OS-Plan9
Projects
None yet
Milestone
Go1.11
Development

No branches or pull requests
2 participants
@0intro @gopherbot