New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
strings: "priority" and "special casing rules" in ToLowerSpecial doc unclear #26654
Comments
The special casing rules here handled by this function are specifically those in the argument There is a bit of background on this at http://www.unicode.org/reports/tr44/#Casemapping. |
@ianlancetaylor - Does this sound okay ?
|
Hi, Can I take this issue as my first contribution? :) |
Sure :) |
@agnivade Thanks, I think the first sentence is fine but I would drop the second sentence. The truth is that if you want case-insensitive string comparison in a specific language you should probably be using golang.org/x/text/search. |
@agnivade @ianlancetaylor I think the term Does this comment sounds good?
|
I think the second sentence just repeats the last part of the first sentence. You can send a CL with only the first sentence. Users can always click on |
Change https://golang.org/cl/127716 mentions this issue: |
@ianlancetaylor I just submitted a PR for this issue - as it is my first one let me know if anything is incorrect. I wasn't sure if anyone was still working on this since a few days had passed - my apologies if I stepped on any toes. |
@kzisme I was working on this, as I can see your CL is under review, you can work on this. Thanks |
It's unclear to me what "priority" and "special casing rules" mean.
The package doc says "For information about UTF-8 strings in Go, see https://blog.golang.org/strings." Searching that page for "special", "case", etc. didn't seem to point to anything related to special casing or priority.
System details
The text was updated successfully, but these errors were encountered: