x/sys/unix: broken on Go 1.6 #26576

hiranya911 · 2018-07-24T22:31:10Z

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (`go version`)?

go version go1.6.4 linux/amd64

What operating system and processor architecture are you using (`go env`)?

GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/travis/gopath"
GORACE=""
GOROOT="/home/travis/.gimme/versions/go1.6.4.linux.amd64"
GOTOOLDIR="/home/travis/.gimme/versions/go1.6.4.linux.amd64/pkg/tool/linux_amd64"
GO15VENDOREXPERIMENT="1"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0"
CXX="g++"
CGO_ENABLED="1"

What did you do?

Some of our CI builds on Go 1.6 suddenly started failing (builds are successful on other Go version)

google.golang.org/grpc/balancer
google.golang.org/grpc/balancer/base
google.golang.org/grpc/balancer/roundrobin
google.golang.org/grpc/codes
google.golang.org/grpc/encoding
google.golang.org/grpc/encoding/proto
google.golang.org/grpc/internal
google.golang.org/grpc/internal/grpcrand
google.golang.org/grpc/internal/backoff
golang.org/x/sys/unix
# golang.org/x/sys/unix
../../golang.org/x/sys/unix/ioctl.go:18: undefined: runtime.KeepAlive
../../golang.org/x/sys/unix/ioctl.go:28: undefined: runtime.KeepAlive
google.golang.org/grpc/internal/envconfig
github.com/golang/protobuf/ptypes/any
google.golang.org/genproto/googleapis/rpc/status
google.golang.org/grpc/keepalive
google.golang.org/grpc/metadata
google.golang.org/grpc/peer
google.golang.org/grpc/stats
github.com/golang/protobuf/ptypes/duration
github.com/golang/protobuf/ptypes/timestamp
github.com/golang/protobuf/ptypes
google.golang.org/grpc/status
google.golang.org/grpc/tap
google.golang.org/grpc/naming
google.golang.org/grpc/resolver/dns
google.golang.org/grpc/resolver/passthrough
google.golang.org/api/iterator
golang.org/x/net/context/ctxhttp
golang.org/x/oauth2/jws
golang.org/x/oauth2/internal
cloud.google.com/go/compute/metadata
google.golang.org/api/googleapi/transport
golang.org/x/oauth2
github.com/golang/protobuf/ptypes/empty
github.com/golang/protobuf/ptypes/struct
github.com/golang/protobuf/ptypes/wrappers
golang.org/x/oauth2/jwt
github.com/golang/protobuf/protoc-gen-go/descriptor
golang.org/x/oauth2/google
google.golang.org/genproto/googleapis/api/annotations
google.golang.org/grpc/credentials/oauth
google.golang.org/genproto/googleapis/type/latlng
cloud.google.com/go/internal/atomiccache
cloud.google.com/go/internal/btree
cloud.google.com/go/internal/fields
google.golang.org/api/googleapi/internal/uritemplates
cloud.google.com/go/internal/optional
cloud.google.com/go/internal/trace
google.golang.org/api/googleapi
google.golang.org/api/gensupport
google.golang.org/api/identitytoolkit/v3
google.golang.org/api/storage/v1
The command "go get -t -v $(go list ./... | grep -v integration)" failed and exited with 2 during .

Issue seems to have been caused by golang/sys@e072cad

The text was updated successfully, but these errors were encountered:

hiranya911 · 2018-07-24T22:44:21Z

It seems runtime.KeepAlive is only present on Go 1.7 and above.

…fetime Change-Id: I42e59149e58bd928d9beb2c6665ce186b377d2a1 Reviewed-on: https://go-review.googlesource.com/125640 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>

bradfitz · 2018-07-24T22:53:36Z

Sorry, Go 1.6 is no longer supported.

If you were using Go 1.6 for App Engine, note that GAE standard supports Go 1.9 (by default) now.

/cc @jba @zombiezen @ianlancetaylor

hiranya911 · 2018-07-24T23:42:55Z

What about other GCP client libraries? They were still building for golang 1.6 last time I checked: https://github.com/GoogleCloudPlatform/google-cloud-go/blob/master/.travis.yml

ianlancetaylor · 2018-07-24T23:44:19Z

Will no one rid of us of this meddlesome 1.6 release?

hiranya911 · 2018-07-24T23:44:50Z

Btw we are observing this break in the Firebase Go library. If Cloud gophers have decided to drop golang 1.6, we can get on board with that and drop 1.6 support as well.

@jba, @broady please advise.

bradfitz · 2018-07-24T23:51:44Z

Will no one rid of us of this meddlesome 1.6 release?

I'm trying, Henry. My understanding was that GAE Standard was the last holdout and with it supporting Go 1.9 now we could move forward. I'd love to get confirmation on that.

jba · 2018-07-25T09:41:36Z

Not quite, Brad. There is a difference between supporting 1.9 and dropping support for 1.6.

Please put this change behind a build tag.

jba · 2018-07-25T09:47:29Z

Sorry, let me be less snarky.

Although 1.9 may be the GAE default, it is still possible to pin to other versions. We know that several projects pin to 1.6. Until an official deprecation policy is announced and implemented, we are obligated to support 1.6.

agnivade · 2018-07-25T10:24:56Z

Until an official deprecation policy is announced and implemented,

It is already there I believe.

Each major Go release is supported until there are two newer major releases

https://golang.org/doc/devel/release.html#policy. So "officially" 1.6 is no longer supported.

jba · 2018-07-25T10:56:43Z

Sorry, @agnivade, I was referring to App Engine, not Go.

bradfitz · 2018-07-25T14:50:41Z

@jba, do we have that documented somewhere?

Let's agree on something and write something down.

We can't have some invisible policy that non-Google Go contributors don't know about.

Please document somewhere what's expected of the Go App Engine libraries and what's expected of the Go libraries (and which). And for which environments. (Standard? Flex? Go 1.6 only? which packages?)

Also, we have no build & test infrastructure setup for older releases anymore.

You never replied to #26302 either, which is about removing Go 1.8 and older support in x/net/http2, which has become a mess of +build tags and files:

https://github.com/golang/net/tree/master/http2

... such messes hinder development. It's just not sustainable to keep supporting Go 1.6.

Perhaps y'all need to vendor old copies of certain golang.org/x/* packages to keep App Engine libraries working, if that's what you've promised.

But I'm not sure what the constraints are. Please document it somewhere.

Once we see & agree upon a policy, then we can move forward with this bug.

dfawley · 2018-07-25T18:04:34Z

Vendoring is the only reasonable solution here. It isn't sustainable to support so many versions of Go. If App Engine was not a Google product, I know what we would do.

jba · 2018-07-25T18:11:10Z

Vendoring doesn't work on App Engine, unfortunately.

bradfitz · 2018-07-25T18:23:46Z

@jba, maybe not with cmd/go's special handling of "vendor" directories, but it works in the general sense: you can copy files from your dependencies into your own GOPATH and manage your own whole GOPATH (your app + your deps) in your VCS.

This can be reverted when golang/go#26576 is resolved.

hiranya911 · 2018-07-26T18:00:58Z

So, what's the way forward here. As it is several builds remain broken:

https://travis-ci.org/GoogleCloudPlatform/google-cloud-go
https://travis-ci.org/firebase/firebase-admin-go

It seems GRPC team disabled the 1.6 CI builds. Is that a reasonable temporary workaround?

golang/x/sys/unix removed support for Go 1.6. Decision on our side pending discussion in golang/go#26576. Disable the E2E test for now to avoid covering other failures. Change-Id: I47fabb89c0ccc5f9e7bef5502bcd71fd3e2b586a Reviewed-on: https://code-review.googlesource.com/30910 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Jonathan Amsterdam <jba@google.com> Reviewed-by: Alexey Alexandrov <aalexand@google.com>

dfawley · 2018-07-26T18:11:12Z

It seems GRPC team disabled the 1.6 CI builds. Is that a reasonable temporary workaround?

I think the only other choice would be to pin your dependencies to versions that support 1.6 in your 1.6 CI build. I.e. cd ...../golang.org/x/sys && git checkout e072cad~1

aalexand · 2018-07-26T18:13:28Z

Or get rid of x/sys dependency?

…

On Thu, Jul 26, 2018 at 11:12 AM dfawley ***@***.***> wrote: It seems GRPC team disabled the 1.6 CI builds. Is that a reasonable temporary workaround? I think the only other choice would be to pin your dependencies to versions that support 1.6 in your 1.6 CI build. I.e. cd ...../ golang.org/x/sys && git checkout e072cad~1 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#26576 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABctwBDYePiSA0M53bMm_gJrLv9p41O5ks5uKgaSgaJpZM4VfBvk> .

-- Alex

jba · 2018-07-26T18:13:43Z

cloud.google.com/go/... has disabled 1.6 in our Travis config.

hiranya911 · 2018-07-26T18:16:15Z

x/sys is a transitive dependency for us (probably coming through the GCP libs we depend on). But pinning to a working revision sounds interesting. I'm going to try that out in a bit.

jba · 2018-07-26T18:16:23Z

@dfawley, can internal/channelz/types_linux.go and internal/syscall/syscall_linux.go be removed for 1.6? They already have a !appengine build tag, so they can't be that critical.

dfawley · 2018-07-26T18:24:14Z

I think it should be fine, but this sounds like kicking the can down the road to me. When will our next dependency break support for Go 1.6?

ChannelZ is a debugging feature in grpc. It has not had appengine support; this commit removes its support for 1.6, too. This change is because in a recent sys/unix commit 1.6 support was broken. See: golang/go#26576 (comment).

jeanbza · 2018-07-26T21:06:07Z

Uh... sorry for the commit spam. Apparently amending + git push -f, despite not making new commits, puts a new entry in linked issues each time. TIL.

jeanbza · 2018-07-26T21:36:39Z

@hiranya911 We've put the 1.6-incompatible code behind build flags in grpc (which google-cloud-go Firestore client uses): grpc/grpc-go#2242. You should now be able to use our GCP clients in 1.6 again. Let me know if that's not the case.

hiranya911 · 2018-07-26T21:48:15Z

@jadekler that indeed fixes the issue for us. Much appreciated 👍

https://travis-ci.org/firebase/firebase-admin-go/jobs/407811247

bradfitz · 2018-10-02T18:39:27Z

The Google stuff broken by this was fixed, so closing this issue. The Go project itself has no plans to change our support policy to support things older than the past two releases.

bradfitz added this to the Unplanned milestone Jul 24, 2018

bradfitz changed the title ~~Build Error from golang.org/x/sys/unix/ioctl.go on Golang 1.6~~ x/sys/unix: broken on Go 1.6 Jul 24, 2018

bradfitz added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Jul 25, 2018

dfawley mentioned this issue Jul 25, 2018

disable go1.6 travis tests grpc/grpc-go#2237

Merged

menghanl pushed a commit to grpc/grpc-go that referenced this issue Jul 25, 2018

disable go1.6 travis tests (#2237)

fe131d6

This can be reverted when golang/go#26576 is resolved.

jeanbza mentioned this issue Jul 26, 2018

update from googleapis googleapis/go-genproto#85

Merged

jeanbza mentioned this issue Jul 26, 2018

remove 1.6 support for channelz grpc/grpc-go#2242

Merged

oklahomer mentioned this issue Jul 31, 2018

Remove Go 1.6 support oklahomer/go-sarah#61

Closed

SpComb mentioned this issue Aug 3, 2018

Go 1.6 build broken: golang.org/x/sys/unix/ioctl.go:18: undefined: runtime.KeepAlive qmsk/e2#33

Closed

rbriski mentioned this issue Sep 12, 2018

Go 1.6 and below no longer work in TravisCI andygrunwald/go-jira#170

Closed

mjrider mentioned this issue Oct 1, 2018

Build failures due to golang 1.6 specific issue home-assistant/cli#114

Closed

bradfitz closed this as completed Oct 2, 2018

HaraldNordgren mentioned this issue Oct 21, 2018

Bump Go versions hoisie/web#216

Closed

jorygeerts mentioned this issue Oct 22, 2018

Fix #33: Low performance due to GC on gzip/zlib writers gemnasium/logrus-graylog-hook#35

Merged

eyberg mentioned this issue Dec 20, 2018

Compilation failure with go 1.6 nanovms/ops#94

Closed

thinkerou mentioned this issue Feb 27, 2019

gin middleware repo remove go1.6/go1.7 support gin-gonic/gin#1782

Closed

torano-toby mentioned this issue Aug 8, 2019

Travis build fails due Go version canthefason/go-watcher#42

Open

golang locked and limited conversation to collaborators Oct 2, 2019

gopherbot added the FrozenDueToAge label Oct 2, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

x/sys/unix: broken on Go 1.6 #26576

x/sys/unix: broken on Go 1.6 #26576

hiranya911 commented Jul 24, 2018

hiranya911 commented Jul 24, 2018

bradfitz commented Jul 24, 2018

hiranya911 commented Jul 24, 2018

ianlancetaylor commented Jul 24, 2018

hiranya911 commented Jul 24, 2018

bradfitz commented Jul 24, 2018

jba commented Jul 25, 2018

jba commented Jul 25, 2018

agnivade commented Jul 25, 2018

jba commented Jul 25, 2018

bradfitz commented Jul 25, 2018

dfawley commented Jul 25, 2018

jba commented Jul 25, 2018

bradfitz commented Jul 25, 2018

hiranya911 commented Jul 26, 2018

dfawley commented Jul 26, 2018

aalexand commented Jul 26, 2018 via email

jba commented Jul 26, 2018

hiranya911 commented Jul 26, 2018

jba commented Jul 26, 2018

dfawley commented Jul 26, 2018

jeanbza commented Jul 26, 2018

jeanbza commented Jul 26, 2018

hiranya911 commented Jul 26, 2018

bradfitz commented Oct 2, 2018

x/sys/unix: broken on Go 1.6 #26576

x/sys/unix: broken on Go 1.6 #26576

Comments

hiranya911 commented Jul 24, 2018

What version of Go are you using (go version)?

What operating system and processor architecture are you using (go env)?

What did you do?

hiranya911 commented Jul 24, 2018

bradfitz commented Jul 24, 2018

hiranya911 commented Jul 24, 2018

ianlancetaylor commented Jul 24, 2018

hiranya911 commented Jul 24, 2018

bradfitz commented Jul 24, 2018

jba commented Jul 25, 2018

jba commented Jul 25, 2018

agnivade commented Jul 25, 2018

jba commented Jul 25, 2018

bradfitz commented Jul 25, 2018

dfawley commented Jul 25, 2018

jba commented Jul 25, 2018

bradfitz commented Jul 25, 2018

hiranya911 commented Jul 26, 2018

dfawley commented Jul 26, 2018

aalexand commented Jul 26, 2018 via email

jba commented Jul 26, 2018

hiranya911 commented Jul 26, 2018

jba commented Jul 26, 2018

dfawley commented Jul 26, 2018

jeanbza commented Jul 26, 2018

jeanbza commented Jul 26, 2018

hiranya911 commented Jul 26, 2018

bradfitz commented Oct 2, 2018

What version of Go are you using (`go version`)?

What operating system and processor architecture are you using (`go env`)?