Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/internal/obj/arm64: wrong instruction not detected #26556

Closed
benshi001 opened this issue Jul 24, 2018 · 1 comment
Closed

cmd/internal/obj/arm64: wrong instruction not detected #26556

benshi001 opened this issue Jul 24, 2018 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unplanned

Comments

@benshi001
Copy link
Member

LDP (R0), (F1, F2) // 010840a9

The above wrong instruction was silently accepted, and generated the same encoding with
LDP (R0), (R1, R2)

The assembler should rise an error for that.
@benshi001 benshi001 self-assigned this Jul 24, 2018
@andybons andybons changed the title cmd/internal/obj/arm64: wrong instruction not deletected cmd/internal/obj/arm64: wrong instruction not detected Jul 24, 2018
@andybons andybons added the NeedsFix The path to resolution is known, but the work has not been done. label Jul 24, 2018
@andybons andybons added this to the Unplanned milestone Jul 24, 2018
@gopherbot
Copy link

Change https://golang.org/cl/125637 mentions this issue: cmd/internal/obj/arm64: fix a bug in the assembler

jeet-parekh pushed a commit to jeet-parekh/go that referenced this issue Jul 31, 2018
@benshi001 @jeet-parekh
cmd/internal/obj/arm64: reject incorrect form of LDP/STP
e415722 
"LDP (R0), (F0, F1)" and "STP (F1, F2), (R0)" are
silently accepted by the arm64 assembler without
any error message. And this CL fixes that bug.

fixes golang#26556.

Change-Id: Ib6fae81956deb39a4ffd95e9409acc8dad3ab2d2
Reviewed-on: https://go-review.googlesource.com/125637
Run-TryBot: Ben Shi <powerman1st@163.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
@golang golang locked and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
3 participants
@andybons @gopherbot @benshi001