Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/cover: tool cover -html draws invisible file chooser #26554

Closed
sblackstone opened this issue Jul 23, 2018 · 3 comments
Closed

cmd/cover: tool cover -html draws invisible file chooser #26554

sblackstone opened this issue Jul 23, 2018 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone

Comments

@sblackstone
Copy link

sblackstone commented Jul 23, 2018

What version of Go are you using (go version)?

go version go1.10.3 darwin/amd64

What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/sblackstone/Library/Caches/go-build"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/sblackstone/code/furious/go"
GORACE=""
GOROOT="/usr/local/Cellar/go/1.10.3/libexec"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.10.3/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/vv/1cv4dp094z5bvysrmzqmzjd00000gn/T/go-build060803460=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

go test ./... -coverprofile=cover.out && go tool cover -html=cover.out

What did you expect to see?

There is a visible select box for choosing which file to look at.

What did you see instead?

A missing-but-clickable file chooser in the profile... (See screenshot w/ HTML)

image

@ALTree ALTree added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 23, 2018
@ALTree ALTree changed the title go tool cover -html draws invisible file chooser... cmd/cover: tool cover -html draws invisible file chooser Jul 23, 2018
@bcmills bcmills added this to the Go1.12 milestone Jul 24, 2018
@dsymonds
Copy link
Contributor

I cannot reproduce this close to head, but I also can't see how this can happen from cmd/cover's side. The HTML it generates for the <select> is quite simple.

Is it possible you have some Chrome extension hiding it? Can you try opening that coverage.html file in an incognito window to check?

@ianlancetaylor ianlancetaylor added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Dec 7, 2018
@ianlancetaylor ianlancetaylor modified the milestones: Go1.12, Go1.13 Dec 7, 2018
@ianlancetaylor
Copy link
Member

@sblackstone See questions above.

@dsymonds
Copy link
Contributor

I'm fairly convinced this isn't a bug in cmd/cover. It's most likely some issue in the user's browser.

@golang golang locked and limited conversation to collaborators Dec 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Development

No branches or pull requests

6 participants