Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: out of memory while executing make.bash #26523

Closed
alevchuk opened this issue Jul 21, 2018 · 8 comments
Closed

runtime: out of memory while executing make.bash #26523

alevchuk opened this issue Jul 21, 2018 · 8 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone
Go1.12

Comments

@alevchuk
Copy link

alevchuk commented Jul 21, 2018 •
edited

Master (go1.11) build process is using more memory than go1.10.3

I was able to build go1.10.3 (June 6) on ARMv6 with 433 MB of RAM (Raspbery Pi Zero W)
Yet, with the latest checkout of 48c7973 (July 10) the build crashes with

# com/compile/internal/ssa
fatal error: runtime: out of memory

The regression was introduces somewhere in the range from June 6 to July 10.

What version of Go are you using (go version)?

48c7973 - bad version
go1.10.3 - good version

i was able to re-pro reliably 2 times on each version

Does this issue reproduce with the latest release?

go1.10.3 is the latest release

What operating system and processor architecture are you using (go env)?

arm

What did you do?

Did building with ./make.bash

What did you expect to see?

build complete

What did you see instead?

see error in screenshot

Build successful on go1.10.3 (June 6)

1 10 3 works

Build runs out of memory on 48c7973 (July 10)

48c7973 broken

img_8530 heic
@alevchuk alevchuk changed the title Memory regression in go build process out of memory when building go Jul 22, 2018
@alevchuk alevchuk changed the title out of memory when building go Out of memory when building go Jul 22, 2018
@agnivade agnivade changed the title Out of memory when building go runtime: out of memory while executing make.bash Jul 22, 2018
@agnivade agnivade added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 22, 2018
@agnivade
Copy link
Contributor

A git bisect would be extremely helpful.

@ysmolski
Copy link
Member

On the side note, it would be cool to have builders automatically report and store with currently absent benchmarking data the memory it took to build the go.

@eliasnaur
Copy link
Contributor

The Go 1.10.3 release might be from June 6, but it doesn't contain all the changes from Go 1.11. So the window of changes is the entire Go 1.11 development window, except for a few backports.

@eliasnaur
Copy link
Contributor

Perhaps #26186 is relevant.

@alevchuk alevchuk mentioned this issue Jul 23, 2018
Closed
@bcmills bcmills mentioned this issue Jul 23, 2018
Closed
@bcmills bcmills added this to the Go1.11 milestone Jul 23, 2018
@randall77
Copy link
Contributor

@alevchuk : could you try patching in https://go-review.googlesource.com/c/go/+/125516 and running again? My bet is that it won't help but it's worth trying.

@agnivade
Copy link
Contributor

Hi @alevchuk, could you try @randall77's suggestion and see if that helps ?

@agnivade agnivade added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Aug 12, 2018
@andybons andybons modified the milestones: Go1.11, Go1.11.1 Aug 25, 2018
@agnivade agnivade mentioned this issue Aug 26, 2018
Closed
@FiloSottile FiloSottile modified the milestones: Go1.11.1, Go1.12 Aug 31, 2018
@benshi001
Copy link
Member

benshi001 commented Sep 4, 2018 •
edited

My raspberry pi 2 has a USB disk as a SWAP, which can avoid this issue.

             total       used       free     shared    buffers     cached
Mem:        945516      83428     862088       6324      10744      37424
-/+ buffers/cache:      35260     910256
Swap:      7919080          0    7919080

@gopherbot
Copy link

Timed out in state WaitingForInfo. Closing.

(I am just a bot, though. Please speak up if this is a mistake or you have the requested information.)

@agnivade agnivade mentioned this issue Sep 18, 2018
Closed
@golang golang locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Milestone
Go1.12
Development

No branches or pull requests
10 participants
@alevchuk @ysmolski @andybons @eliasnaur @FiloSottile @agnivade @bcmills @randall77 @gopherbot @benshi001