Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: remove defers for increasing speed #26502

Closed
wants to merge 1 commit into from

Conversation

lcd1232
Copy link

@lcd1232 lcd1232 commented Jul 20, 2018

No description provided.

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Jul 20, 2018
@gopherbot
Copy link

Message from Gerrit User 5976:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/125275.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gerrit User 7435:

Patch Set 1:

What performance problem is solved by this CL? The change is unlikely to be accepted without a good reason.


Please don’t reply on this GitHub thread. Visit golang.org/cl/125275.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gerrit User 5065:

Patch Set 1: Code-Review-2

Yeah, sorry, this isn't something we want to accept.

We prefer defer unless there's a good performance reason and this code isn't hot so I don't see any reason to micro-optimize it.


Please don’t reply on this GitHub thread. Visit golang.org/cl/125275.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

This PR is being closed because golang.org/cl/125275 has been abandoned.

@gopherbot gopherbot closed this Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants