proposal: x/build/cmd/gopherbot: add label to indicate issue has CL #26494
Comments
agnivade
changed the title
|
Change https://golang.org/cl/125196 mentions this issue: |
|
One concern is that a CL can be a partial "update" as opposed to a complete "fix". We wouldn't want someone thinking that an issue with only update(s) doesn't need any more code uploaded. So an alternative is to have more granular CL labels than just existence, though maybe existence is good enough for now. /cc @andybons |
|
Thanks for the proposal. One can see issues that don't have a CL attached to them via searching: https://github.com/golang/go/issues?utf8=✓&q=is%3Aopen+label%3A"help+wanted"+NOT+"mentions+this+issue" I find this adequate for finding issues that don't have a CL attached, and as @meirf stated above, a CL being associated doesn't always mean that there's not more to do. If I'm missing something, please let me know. I'd rather not add more labels if there exists a relatively easy way of doing the same thing without them. |
|
Thanks for sharing an option that works @andybons! Following your pattern searching for How can we make this more obvious to people who are new to contributing, or to people who don't have the tribal knowledge that the Go team has? |
|
@leighmcculloch that’s a good question. Perhaps adding something to https://golang.org/doc/contribute.html? |
|
Change https://golang.org/cl/125355 mentions this issue: |
|
@andybons I've followed your suggestion and opened a CL ☝️ adding something to contribute.html. |
|
Great! I’ll have a look this coming week. Thank you. |
For contributors looking for new issues to contribute to it can be difficult to find issues that need a fix and don't already have a fix being considered. There are several labels that help guide the way already, like `NeedsFix`, `HelpWanted`. But many issues with this label will already have a CL. For new contributors this can be especially difficult. Fixes #26494 Change-Id: Ifd38ea65e362b4c580207a06f959646e49ac594f GitHub-Last-Rev: 6d2b544 GitHub-Pull-Request: #26516 Reviewed-on: https://go-review.googlesource.com/125355 Reviewed-by: Andrew Bonventre <andybons@golang.org> Run-TryBot: Andrew Bonventre <andybons@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
For contributors looking for new issues to contribute to it can be difficult to find issues that need a fix and don't already have a fix being considered. There are several labels that help guide the way already, like
NeedsFix,HelpWanted. But many issues with this label will already have a CL.It'd be helpful to be able to search for issues that do not have a CL.
Could we add a label to indicate that an issue has a CL? Gobot could add the label when it posts the comment to the issue stating a CL has been pushed.
The text was updated successfully, but these errors were encountered: