x/net/http2: support http2 proxy connections #26479

iaguis · 2018-07-19T16:33:51Z

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (`go version`)?

go version go1.10.3 linux/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (`go env`)?

GOARCH="amd64"
GOBIN=""
GOCACHE="..."
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="..."
GORACE=""
GOROOT="/usr/lib/go"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build612803013=/tmp/go-build -gno-record-gcc-switches"

What did you do?

I have an HTTP/2 proxy (I tested a custom one and https://github.com/caddyserver/forwardproxy) and when trying to connect through it from a client using HTTP/2 I get an error. This does not happen if I don't use HTTP/2.

Here's my code:

package main

import (
	"crypto/tls"
	"fmt"
	"io/ioutil"
	"net/http"
	"os"

	"golang.org/x/net/http2"
)

func main() {
	tr := &http.Transport{
		TLSClientConfig: &tls.Config{InsecureSkipVerify: true},
		Proxy:           http.ProxyFromEnvironment,
	}

	if err := http2.ConfigureTransport(tr); err != nil {
		fmt.Fprintf(os.Stderr, "error configuring transport: %v\n", err)
		os.Exit(1)
	}

	client := &http.Client{Transport: tr}
	rsp, err := client.Get("https://google.com")
	if err != nil {
		fmt.Fprintf(os.Stderr, "error getting: %v\n", err)
		os.Exit(1)
	}
	defer rsp.Body.Close()

	buf, err := ioutil.ReadAll(rsp.Body)
	if err != nil {
		fmt.Fprintf(os.Stderr, "error reading response: %v\n", err)
		os.Exit(1)
	}

	fmt.Printf("Response: %s\n", string(buf))
}

If I comment out the http2.ConfigureTransport() call (so it will use HTTP/1.1) it works fine.

What did you expect to see?

A successful connection.

What did you see instead?

On the proxy server:

2018/07/19 18:30:25 http2: server connection from 127.0.0.1:54850 on 0xc420174b60
2018/07/19 18:30:25 http2: server: error reading preface from client 127.0.0.1:54850: bogus greeting "CONNECT google.com:443 H"

On the client:

2018/07/19 18:30:25 http2: Transport failed to get client conn for google.com:443: http2: no cached connection was available
error getting: Get https://google.com: malformed HTTP response "\x00\x00\x18\x04\x00\x00\x00\x00\x00\x00\x05\x00\x10\x00\x00\x00\x03\x00\x00\x00\xfa\x00\x06\x00\x10\x01@\x00\x04\x00\x10\x00\x00"

The text was updated successfully, but these errors were encountered:

agnivade · 2018-07-19T16:53:53Z

Seems like a duplicate of #21336 ?

/cc @bradfitz

bradfitz · 2018-07-19T16:59:18Z

I think they're different bugs.

This is more of a documentation or feature request to support http2 proxies. We only support http1 proxies currently.

shivakumargn · 2020-07-08T15:20:50Z

Is there any plan to support http2 proxy?

crowfrog · 2020-07-29T01:18:50Z

same question about plan for this feature. :)

g00nix · 2021-03-21T00:47:57Z

Currently most people implement HTTPS proxies in Go with http.Hijacker which does not support http2, which mostly means you have to disable http2 completely with TLSNextProto: make(map[string]func(*http.Server, *tls.Conn, http.Handler)).

We can start to do some tricks and hack our way into getting it working, but official support from GoLang into this direction would be a lot better for everybody.

anupamasok · 2021-05-29T05:56:25Z

Currently most people implement HTTPS proxies in Go with http.Hijacker which does not support http2, which mostly means you have to disable http2 completely with TLSNextProto: make(map[string]func(*http.Server, *tls.Conn, http.Handler)).

We can start to do some tricks and hack our way into getting it working, but official support from GoLang into this direction would be a lot better for everybody.

I was looking for a way to Achieve HTTP2 with proxy added. Details. Could you elaborate the "We can start to do some tricks and hack our way into getting it working" @g00nix

g00nix · 2021-06-11T20:39:48Z

I was looking for a way to Achieve HTTP2 with proxy added. Details. Could you elaborate the "We can start to do some tricks and hack our way into getting it working" @g00nix

We should be able to get a http2 proxy working by avoiding net/http completely and just going at a lower level to create the TCP connection and the TLS handshake. I managed to get it working for a transparent proxy, but never invested the time to get this done for a normal proxy.

However it would be better if this was just supported by the official lib, than having to completely rewrite the proxy functionality of net/http.

chew351 · 2021-09-15T12:06:21Z

Is there any plan to support http2 proxy?

Guys， Is there any plan to support http2 proxy?
It’s helpfull for using net/http2 in a cluster

Thanks
zcy

elgohr · 2022-01-05T20:52:45Z

I guess this dialer would be a good workaround for now https://github.com/mwitkow/go-http-dialer

fbuetler · 2024-03-15T16:55:56Z

This is still an issue with go 1.21. What is the roadmap for this feature? Is it a tricky one to implement?

We should be able to get a http2 proxy working by avoiding net/http completely and just going at a lower level to create the TCP connection and the TLS handshake.

We did the same for an explicit forward proxy.

agnivade changed the title ~~net/http: http2 connections to a proxy don't seem to work~~ x/net/http2: support http2 proxy connections Jul 19, 2018

agnivade added the FeatureRequest label Jul 19, 2018

agnivade added this to the Unplanned milestone Jul 19, 2018

riking mentioned this issue Aug 26, 2018

proposal: x/net/http2: experiment with Extended CONNECT draft #27244

Closed

nhooyr mentioned this issue Jul 15, 2019

WebSockets over HTTP/2 nhooyr/websocket#4

Open

rob05c mentioned this issue Dec 11, 2019

Add TO Go cdns/health and cdns/{name}/health apache/trafficcontrol#2305

Merged

ignoramous mentioned this issue Sep 19, 2020

User feedback: Proxy mode celzero/rethink-app#45

Closed

asalih mentioned this issue Sep 21, 2020

How to send request using HTTP/2.0 ? gocolly/colly#515

Closed

toothrot mentioned this issue Dec 6, 2021

net/http2: client immediately close most of connections via forward proxy even if idleConn was configured #50000

Closed

mmatczuk mentioned this issue Feb 22, 2023

martian: allow to use http2 connection to upstream saucelabs/forwarder#239

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

x/net/http2: support http2 proxy connections #26479

x/net/http2: support http2 proxy connections #26479

iaguis commented Jul 19, 2018

agnivade commented Jul 19, 2018

bradfitz commented Jul 19, 2018

shivakumargn commented Jul 8, 2020

crowfrog commented Jul 29, 2020

g00nix commented Mar 21, 2021

anupamasok commented May 29, 2021

g00nix commented Jun 11, 2021

chew351 commented Sep 15, 2021

elgohr commented Jan 5, 2022

fbuetler commented Mar 15, 2024

x/net/http2: support http2 proxy connections #26479

x/net/http2: support http2 proxy connections #26479

Comments

iaguis commented Jul 19, 2018

What version of Go are you using (go version)?

Does this issue reproduce with the latest release?

What operating system and processor architecture are you using (go env)?

What did you do?

What did you expect to see?

What did you see instead?

agnivade commented Jul 19, 2018

bradfitz commented Jul 19, 2018

shivakumargn commented Jul 8, 2020

crowfrog commented Jul 29, 2020

g00nix commented Mar 21, 2021

anupamasok commented May 29, 2021

g00nix commented Jun 11, 2021

chew351 commented Sep 15, 2021

elgohr commented Jan 5, 2022

fbuetler commented Mar 15, 2024

What version of Go are you using (`go version`)?

What operating system and processor architecture are you using (`go env`)?