Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/perf/internal/stats: test failure on s390x with Golang 1.11 beta 1 #26477

Closed
eclipseo opened this issue Jul 19, 2018 · 9 comments
Closed

x/perf/internal/stats: test failure on s390x with Golang 1.11 beta 1 #26477

eclipseo opened this issue Jul 19, 2018 · 9 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.11

Comments

@eclipseo
Copy link

This test failure only affects s390x architecture with Golang 1.11 beta 1. It was working before.
This is using the latest git.

Testing: "/builddir/build/BUILD/perf-2ce0818a26175593d58f0f5ddb67631b9918296b/_build/src/golang.org/x/perf/internal/stats"
+ GOPATH=/builddir/build/BUILD/perf-2ce0818a26175593d58f0f5ddb67631b9918296b/_build:/usr/share/gocode
+ go test -buildmode pie -compiler gc -ldflags '-extldflags '\''-Wl,-z,relro   -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld '\'''
--- FAIL: TestNormalDist (0.00s)
    util_test.go:101: want {Mu:0 Sigma:1}.CDF(10000)=1, got 3.0600400278046567e+65
FAIL
exit status 1
FAIL	golang.org/x/perf/internal/stats	0.062s
@gopherbot gopherbot added this to the Unreleased milestone Jul 19, 2018
@eclipseo eclipseo changed the title x/perf/internal/stats: test failure on s390x amd Golang 1.11 beta 1 x/perf/internal/stats: test failure on s390x with Golang 1.11 beta 1 Jul 19, 2018
@bcmills
Copy link
Contributor

bcmills commented Jul 20, 2018

CC @mundaym

@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 20, 2018
@mundaym mundaym self-assigned this Jul 20, 2018
@gopherbot
Copy link

Change https://golang.org/cl/125276 mentions this issue: math: remove Erfc assembly for s390x

@mundaym mundaym modified the milestones: Unreleased, Go1.11 Jul 20, 2018
@mundaym
Copy link
Member

mundaym commented Jul 20, 2018

This looks like a problem with the Erfc s390x assembly. The test doesn't pass with Go 1.9.x and Go 1.10.x either, so it's not a regression.

@billotosyr can you take a look and see if there is an easy fix for the assembly? Otherwise we should probably remove it for this release.

@randall77
Copy link
Contributor

Yes, we should fix this one way or the other before the release.
We should also pull this test into the stdlib if we can.
I'm going to mark as a release blocker.

@randall77 randall77 added release-blocker NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jul 24, 2018
@gopherbot
Copy link

Change https://golang.org/cl/125641 mentions this issue: math: add tests for erf and erfc

@billotosyr
Copy link

Working on this today. In this failing test, erfc is being called with an argument of ~ -7000, which is way way outside it's expected range of application. The go version of erfc passes because it tests if the input argument is out of reasonable range (-28 to 28). So to fix erfc I will also have to put such a test in. Not too hard to do, of course.

@randall77
Copy link
Contributor

Can we get this fix in ASAP? We'd like to do a release candidate on Wednesday.

@billotosyr
Copy link

yes - just about to put up a CL

@gopherbot
Copy link

Change https://golang.org/cl/127119 mentions this issue: math: ensure Erfc is not called with out-of-expected-range arguments on s390x

gopherbot pushed a commit that referenced this issue Aug 3, 2018
@randall77
math: add tests for erf and erfc
51ddeb9 
Test large but not infinite arguments.

This CL adds a test which breaks s390x.  Don't submit until
a fix for that is figured out.

Update #26477

Change-Id: Ic86739fe3554e87d7f8e15482875c198fcf1d59c
Reviewed-on: https://go-review.googlesource.com/125641
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@golang golang locked and limited conversation to collaborators Aug 3, 2019
@rsc rsc unassigned mundaym Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Milestone
Go1.11
Development

No branches or pull requests
6 participants
@bcmills @randall77 @gopherbot @billotosyr @mundaym @eclipseo