Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: add more verbose comments in Caller method #26437

Closed
minaevmike opened this issue Jul 18, 2018 · 4 comments
Closed

runtime: add more verbose comments in Caller method #26437

minaevmike opened this issue Jul 18, 2018 · 4 comments
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.12

Comments

@minaevmike
Copy link
Contributor

https://github.com/golang/go/blob/master/src/runtime/extern.go#L179
1+skip-1 makes no sense, i think i can be converted to skip or some comments can be added to discribe why we make +1-1.
@ianlancetaylor
Copy link
Contributor

For the record, the -1 was added in https://golang.org/cl/4810054, when the code was changed to ask for two PC values. At this point we should probably just drop it.

@ianlancetaylor ianlancetaylor added help wanted NeedsFix The path to resolution is known, but the work has not been done. labels Jul 18, 2018
@ianlancetaylor ianlancetaylor added this to the Unplanned milestone Jul 18, 2018
@wingyplus
Copy link
Contributor

So we can remove +1-1 in L179. Am I right?

@ianlancetaylor
Copy link
Contributor

Yes.

@gopherbot
Copy link

Change https://golang.org/cl/124895 mentions this issue: runtime: remove +1-1 when asking PC values

@bradfitz bradfitz modified the milestones: Unplanned, Go1.12 Jul 19, 2018
@golang golang locked and limited conversation to collaborators Aug 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.12
Development

No branches or pull requests
5 participants
@bradfitz @wingyplus @minaevmike @ianlancetaylor @gopherbot