New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filepath: updates doc to give case where WalkFunc info arg may be nil #26435

Closed

jackxbritton wants to merge 1 commit into golang:master from jackxbritton:issue-26425

Contributor

jackxbritton commented Jul 18, 2018

If a filepath.WalkFunc is called with an non-nil err argument, it's possible
that the info argument will be nil. The comment above filepath.WalkFunc now
reflects this.

Fixes #26425

googlebot added the cla: yes label

gopherbot commented Jul 18, 2018

Message from Gerrit User 5976:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/124635.
After addressing review feedback, remember to publish your drafts!

gopherbot force-pushed the master branch 5 times, most recently from 07b8191 to a371bc2 Compare

July 18, 2018 10:07

gopherbot commented Jul 18, 2018

Message from Gerrit User 5206:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/124635.
After addressing review feedback, remember to publish your drafts!

jackxbritton force-pushed the issue-26425 branch from 4f7ec7a to 86129d0 Compare

July 18, 2018 19:10


          filepath: updates doc to give case where WalkFunc info arg may be nil

553fc26

If a filepath.WalkFunc is called with an non-nil err argument, it's possible
that the info argument will be nil. The comment above filepath.WalkFunc now
reflects this.

Fixes golang#26425

jackxbritton force-pushed the issue-26425 branch from 86129d0 to 553fc26 Compare

July 18, 2018 19:11

gopherbot commented Jul 18, 2018

Message from Gerrit User 12446:

Uploaded patch set 3: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/124635.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Jul 18, 2018

Message from Gerrit User 12446:

Uploaded patch set 4: New patch set was added with same tree, parent, and commit message as Patch Set 3.

Please don’t reply on this GitHub thread. Visit golang.org/cl/124635.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Jul 18, 2018

Message from Gerrit User 5206:

Patch Set 4: Code-Review+2

Thanks.

Please don’t reply on this GitHub thread. Visit golang.org/cl/124635.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


          filepath: updates doc to give case where WalkFunc info arg may be nil

4016de0

If a filepath.WalkFunc is called with an non-nil err argument, it's possible
that the info argument will be nil. The comment above filepath.WalkFunc now
reflects this.

Fixes #26425

Change-Id: Ib9963b3344587d2993f1698c5a801f2d1286856b
GitHub-Last-Rev: 553fc26
GitHub-Pull-Request: #26435
Reviewed-on: https://go-review.googlesource.com/124635
Reviewed-by: Ian Lance Taylor <iant@golang.org>

gopherbot commented Jul 18, 2018

This PR is being closed because golang.org/cl/124635 has been merged.

gopherbot closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment