http/internal: document final CRLF behavior on chunkedWriter #26410
Conversation
googlebot
added
the
cla: yes
|
Message from Gerrit User 12446: Uploaded patch set 2: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/124255. |
|
Message from Gerrit User 12446: Uploaded patch set 3: New patch set was added with same tree, parent, and commit message as Patch Set 2. Please don’t reply on this GitHub thread. Visit golang.org/cl/124255. |
|
Message from Gerrit User 5065: Patch Set 3: Code-Review-2 I don't think this is correct. We intentionally don't send the double CRLF because that's where trailers go, and Go fully supports HTTP trailers. Can you file a bug with the problem before sending a fix? I don't know what you're actually having a problem with that led you to send this. Please don’t reply on this GitHub thread. Visit golang.org/cl/124255. |
|
Message from Gerrit User 25196: Patch Set 3: Oh I see why you think it's incorrect. transferWriter uses chunkedWriter and writes its own final CRLF. httputil exposes NewChunkedWriter though but does not send the final CRLF. Is this just a documentation issue instead? Please don’t reply on this GitHub thread. Visit golang.org/cl/124255. |
|
Message from Gerrit User 5065: Patch Set 3:
Again, that's a solution, but now I can guess your problem. Yes, httputil.NewChunkWriter writes "chunk" and "last-chunk" (in the grammar of the RFC), not Chunk-Body. Want to send a documentation change instead? Please don’t reply on this GitHub thread. Visit golang.org/cl/124255. |
|
Message from Gerrit User 25196: Patch Set 3:
Sure. I'll amend. Please don’t reply on this GitHub thread. Visit golang.org/cl/124255. |
Change-Id: I0f76b40dbfda2d382c88aec377db1851c4ac7441
edaniels
force-pushed
the
fix_chunked_writer
branch
from
16ee04a
to
ab42559
Compare
|
Message from Gerrit User 12446: Uploaded patch set 5: New patch set was added with same tree, parent, and commit message as Patch Set 4. Please don’t reply on this GitHub thread. Visit golang.org/cl/124255. |
|
Message from Gerrit User 25196: Patch Set 6: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/124255. |
|
Message from Gerrit User 12446: Uploaded patch set 7: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/124255. |
|
Message from Gerrit User 12446: Uploaded patch set 8: New patch set was added with same tree, parent, and commit message as Patch Set 7. Please don’t reply on this GitHub thread. Visit golang.org/cl/124255. |
|
Message from Gerrit User 25196: Patch Set 8: The bot is being wonky with me updating the CR title / details. Please don’t reply on this GitHub thread. Visit golang.org/cl/124255. |
edaniels
changed the title
|
Message from Gerrit User 12446: Uploaded patch set 9: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/124255. |
|
Message from Gerrit User 12446: Uploaded patch set 10: New patch set was added with same tree, parent, and commit message as Patch Set 9. Please don’t reply on this GitHub thread. Visit golang.org/cl/124255. |
|
Message from Gerrit User 25196: Patch Set 10: There we go. Ready for another look Brad. Please don’t reply on this GitHub thread. Visit golang.org/cl/124255. |
|
Message from Gerrit User 5065: Patch Set 10: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/124255. |
Change-Id: I0f76b40dbfda2d382c88aec377db1851c4ac7441 Change-Id: I0f76b40dbfda2d382c88aec377db1851c4ac7441 GitHub-Last-Rev: ab42559 GitHub-Pull-Request: #26410 Reviewed-on: https://go-review.googlesource.com/124255 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
|
This PR is being closed because golang.org/cl/124255 has been merged. |
Change-Id: I0f76b40dbfda2d382c88aec377db1851c4ac7441