New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: run git log with --no-show-signature #26389

Closed

magiconair wants to merge 1 commit into golang:master from magiconair:issue-26388

Contributor

magiconair commented Jul 14, 2018

Git timestamp parsing is broken when fetching modules if the
local git configuration has 'log.showsignature=true'.

Fixes #26388


          cmd/go: run git log with --no-show-signature

96f988c

Git timestamp parsing is broken when fetching modules if the
local git configuration has 'log.showsignature=true'.

Fixes #26388

googlebot added the cla: yes label

gopherbot commented Jul 14, 2018

Message from Gerrit User 13550:

Patch Set 1: Run-TryBot+1 Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/123958.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Jul 14, 2018

Message from Gerrit User 5976:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=2e7b875a

Please don’t reply on this GitHub thread. Visit golang.org/cl/123958.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Jul 14, 2018

Message from Gerrit User 5976:

Patch Set 1: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/123958.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Jul 16, 2018

Message from Gerrit User 6365:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/123958.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Jul 17, 2018

Message from Gerrit User 5045:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/123958.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Jul 17, 2018

Message from Gerrit User 6365:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/123958.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Jul 17, 2018

Message from Gerrit User 5045:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/123958.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Jul 17, 2018

Message from Gerrit User 5056:

Patch Set 1: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/123958.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


          cmd/go: run git log with --no-show-signature

b9a764f

Git timestamp parsing is broken when fetching modules if the
local git configuration has 'log.showsignature=true'.

Fixes #26388

Change-Id: I47f92381784072335a2a465de56092106c616108
GitHub-Last-Rev: 96f988c
GitHub-Pull-Request: #26389
Reviewed-on: https://go-review.googlesource.com/123958
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
Reviewed-by: Russ Cox <rsc@golang.org>
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>

gopherbot commented Jul 17, 2018

This PR is being closed because golang.org/cl/123958 has been merged.

gopherbot closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment