Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: go mod fails with git showsignature=true #26388

Closed
magiconair opened this issue Jul 14, 2018 · 2 comments
Closed

cmd/go: go mod fails with git showsignature=true #26388

magiconair opened this issue Jul 14, 2018 · 2 comments
Labels
FrozenDueToAge modules NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@magiconair
Copy link
Contributor

magiconair commented Jul 14, 2018

What version of Go are you using (go version)?

go version devel +c2eba53e7f Sat Jul 14 06:48:21 2018 +0000 darwin/amd64

Does this issue reproduce with the latest release?

yes

What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/frank/Library/Caches/go-build"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/frank"
GOPROXY=""
GORACE=""
GOROOT="/Users/frank/sdk/gotip"
GOTMPDIR=""
GOTOOLDIR="/Users/frank/sdk/gotip/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/frank/devel/spider/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/1p/s7jtgnc57s56py3x7t9mzm2c0000gn/T/go-build876139678=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

git config --global log.showsignature true
go mod -require github.com/magiconair/properties@v1.7.4
go: finding github.com/magiconair/properties v1.7.4
go: github.com/magiconair/properties@v1.7.4: invalid time from git log: "gpg: Signature made Tue Oct 31 21:37:52 2017 CET\ngpg:                using RSA key 13F0C1ADBE7A838644816B1E4D65C6EAEC87DECD\ngpg: Good signature from \"Frank Schroeder <frank.schroeder@gmail.com>\" [ultimate]\ngpg:                 aka \"Frank Schroeder <frschroeder@ebay.com>\" [ultimate]\ngpg:                 aka \"Frank Schroeder <frank.schroeder@go-left.com>\" [ultimate]\ngpg:                 aka \"Frank Schroeder <frank@hashicorp.com>\" [ultimate]\ngpg:                 aka \"[jpeg image of size 5807]\" [ultimate]\ngpg:                 aka \"Frank Schroeder <frank.schroeder@joyent.com>\" [ultimate]\ngpg:                 aka \"Frank Schroeder <frank@northvolt.com>\" [ultimate]\ngpg:                 aka \"Frank Schroeder <frank.schroeder@northvolt.com>\" [ultimate]\nd419a98cdbed11a922bf76f257b7c4be79b50e73 1509482266 grafted, tag: v1.7.4"
go: error loading module requirements

Adding --no-show-signature to modfetch for git fixes this. In the meantime you can work around this with

git config [--global] log.showsignature false
@magiconair
Copy link
Contributor Author

Oh, we can do pull requests now. Lets try this.

@gopherbot
Copy link

Change https://golang.org/cl/123958 mentions this issue: cmd/go: run git log with --no-show-signature

@mvdan mvdan added the modules label Jul 14, 2018
@mvdan mvdan added this to the Go1.11 milestone Jul 14, 2018
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 16, 2018
@golang golang locked and limited conversation to collaborators Jul 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge modules NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

4 participants