Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: CL 123755 broke all Windows builders #26371

Closed
mvdan opened this issue Jul 13, 2018 · 1 comment
Closed

cmd/go: CL 123755 broke all Windows builders #26371

mvdan opened this issue Jul 13, 2018 · 1 comment
Labels
FrozenDueToAge OS-Windows release-blocker
Milestone
Go1.11

Comments

@mvdan
Copy link
Member

mvdan commented Jul 13, 2018

Seems to be because the trybots weren't ran before merging? https://go-review.googlesource.com/c/go/+/123755

--- FAIL: TestModFindModulePath (0.01s)
    mod_test.go:217: remove C:\Users\gopher\AppData\Local\Temp\gotest721722731\work: The process cannot access the file because it is being used by another process.
    asm_386.s:568: ended in C:\Users\gopher\AppData\Local\Temp\gotest721722731\work
FAIL
FAIL	cmd/go	74.332s

/cc @rsc
@mvdan mvdan added this to the Go1.11 milestone Jul 13, 2018
@oiooj
Copy link
Member

oiooj commented Jul 14, 2018

Fixed by CL 123757.

@oiooj oiooj closed this as completed Jul 14, 2018
@golang golang locked and limited conversation to collaborators Jul 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge OS-Windows release-blocker
Projects
None yet
Milestone
Go1.11
Development

No branches or pull requests
3 participants
@oiooj @mvdan @gopherbot