Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: test WebAssembly Fetch implementation of Transport #26358

Open
odeke-em opened this issue Jul 12, 2018 · 4 comments
Open

net/http: test WebAssembly Fetch implementation of Transport #26358

odeke-em opened this issue Jul 12, 2018 · 4 comments
Labels
arch-wasm WebAssembly issues help wanted NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Backlog

Comments

@odeke-em
Copy link
Member

While taking a look at CL https://go-review.googlesource.com/c/go/+/123537 for #26349, a recommendation was that we should add tests to avoid regressions such as in that issue raised. @bradfitz added a reminder in #26051 (comment)
@odeke-em odeke-em added the arch-wasm WebAssembly issues label Jul 12, 2018
@odeke-em odeke-em added this to the Go1.12 milestone Jul 12, 2018
@odeke-em
Copy link
Member Author

/cc @johanbrandhorst @neelance too

@gopherbot gopherbot mentioned this issue Jul 12, 2018
Closed
@odeke-em
Copy link
Member Author

Also a superset of #25933

@bradfitz bradfitz changed the title all: add tests for WASM code when wasm browser-based builders are available net/http: test WebAssembly Fetch implementation of Transport Jul 12, 2018
@bradfitz bradfitz added Testing An issue that has been verified to require only test changes, not just a test failure. help wanted NeedsFix The path to resolution is known, but the work has not been done. labels Jul 12, 2018
@bradfitz
Copy link
Contributor

Retitled. This depends on #26051. Once #26051, then this shouldn't be too much work.

@andybons andybons modified the milestones: Go1.12, Go1.13 Feb 12, 2019
@johanbrandhorst johanbrandhorst mentioned this issue Apr 19, 2019
Open
@dmitshur
Copy link
Contributor

This might've helped with #31736 too.

@andybons andybons modified the milestones: Go1.13, Go1.14 Jul 8, 2019
@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arch-wasm WebAssembly issues help wanted NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@bradfitz @rsc @andybons @dmitshur @odeke-em