Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/cgo: CL 123177 broke all darwin builders #26355

Closed
mvdan opened this issue Jul 12, 2018 · 10 comments
Closed

cmd/cgo: CL 123177 broke all darwin builders #26355

mvdan opened this issue Jul 12, 2018 · 10 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Milestone
Go1.11

Comments

@mvdan
Copy link
Member

mvdan commented Jul 12, 2018

The error logs are all a bit different, but it looks like the CL is to blame.

# _/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test/issue24161e0
issue24161e0/main.go:19:2: could not determine kind of name for C.SecKeyCreateSignature
issue24161e0/main.go:19:29: could not determine kind of name for C.kSecKeyAlgorithmECDSASignatureDigestX962SHA1
# _/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test/issue24161e1
issue24161e1/main.go:22:2: could not determine kind of name for C.SecKeyCreateSignature
issue24161e1/main.go:22:29: could not determine kind of name for C.kSecKeyAlgorithmECDSASignatureDigestX962SHA1
# _/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test/issue24161e2
issue24161e2/main.go:24:2: could not determine kind of name for C.SecKeyCreateSignature
issue24161e2/main.go:24:29: could not determine kind of name for C.kSecKeyAlgorithmECDSASignatureDigestX962SHA1
FAIL	_/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test [build failed]
2018/07/12 12:24:44 Failed: exit status 2

https://build.golang.org/log/3a95705141a8316a8c9e0514974378d0aaa8f866
https://build.golang.org/log/5c52fc2c58ad510449b5028c614c74ea4e82460f
https://build.golang.org/log/5940718e6731ee4f216d2fb3c6b5daeddaffd753

/cc @randall77 @ianlancetaylor
@mvdan mvdan added this to the Go1.11 milestone Jul 12, 2018
@ianlancetaylor ianlancetaylor added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker labels Jul 12, 2018
@bradfitz
Copy link
Contributor

(Mac trybots are still down from a previous outage. I've been putting off restoring them until trybots handled disappearing machines better.)

@odeke-em
Copy link
Member

@mvdan perhaps the builders are using a stale version of Go to run ./all.test? I ask because locally I have run ./all.test on my Mac with the latest Go tip and no failures locally
screen shot 2018-07-12 at 3 04 09 pm

@mvdan
Copy link
Member Author

mvdan commented Jul 12, 2018

@odeke-em I wouldn't know - I'm nowhere near a Mac machine to investigate this :)

@randall77
Copy link
Contributor

Maybe the Security framework is not reachable? I would expect the include of Security.h to fail in that case, though.
Seems to work on a gomote'd machine just fine.
Maybe an OS version thing? Looks like the 10.12 builders are ok, but not the 10.10 and 10.11 ones.

@randall77
Copy link
Contributor

Indeed, the functions used in the test are 10.12+. Will fix.

@odeke-em
Copy link
Member

Maybe an OS version thing? Looks like the 10.12 builders are ok, but not the 10.10 and 10.11 ones.

@randall77 in deed, same thoughts here #26355 (comment), thanks for the articulation that the builders are using a stale Go version i.e. 10.10 and 10.11 :)

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/123715 mentions this issue: misc/cgo/test: fix issue 24161 test for 1.11 and earlier

@randall77
Copy link
Contributor

@odeke-em It's not the Go version, it's the Mac OSX version.

@odeke-em
Copy link
Member

Ahh I see, thanks!

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/123959 mentions this issue: misc/cgo: fix test on iOS

gopherbot pushed a commit that referenced this issue Jul 15, 2018
@randall77
misc/cgo: fix test on iOS
2598ed0 
The test in CL 123715 doesn't work on iOS, it needs to use a different
version scheme to determine whether SecKeyAlgorithm and friends exist.
Restrict the old version test to OSX only.

The same problem occurs on iOS: the functions tested don't exist before
iOS 10.  But we don't have builders below iOS 10, so it isn't a big issue.
If we ever get older builders, or someone wants to run all.bash on an
old iOS, they'll need to figure out the right incantation.

Update #24161
Update #26355

Change-Id: Ia3ace86b00486dc172ed00c0c6d668a95565bff7
Reviewed-on: https://go-review.googlesource.com/123959
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/124075 mentions this issue: misc/cgo: fix darwin test, again

gopherbot pushed a commit that referenced this issue Jul 16, 2018
@randall77
misc/cgo: fix darwin test, again
baebc7f 
TARGET_OS_OSX is the right macro, but it also was only introduced
in 1.12.  For 1.11 and earlier a reasonable substitution is
TARGET_OS_IPHONE == 0.

Update #24161
Update #26355

Change-Id: I5f43c463d14fada9ed1d83cc684c7ea05d94c5f3
Reviewed-on: https://go-review.googlesource.com/124075
Run-TryBot: Keith Randall <khr@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Jul 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Projects
None yet
Milestone
Go1.11
Development

No branches or pull requests
6 participants
@bradfitz @ianlancetaylor @mvdan @odeke-em @randall77 @gopherbot