New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto/tls: generate_cert.go is out of date in weekly #2635
Labels
Milestone
Comments
Labels changed: added priority-go1, removed priority-triage. Owner changed to @agl. Status changed to Accepted. |
http://golang.org/cl/5512043 Status changed to Started. |
This issue was closed by revision d5e6b8d. Status changed to Fixed. |
I think it's a nice example. It shows people who are using ListenAndServeTLS for the first time how to use flag, crypto/tls and time, and how to do a little file manipulation. If this is removed, or if it won't be supported, may I suggest that the documentation for net/http.ListenAndServeTLS is changed from: "One can use generate_cert.go in crypto/tls to generate cert.pem and key.pem." to something like: "One can generate cert.pem and key.pem using OpenSSL: # openssl genrsa -out key.pem 2048 # openssl req -new -key key.pem -out req.csr # openssl x509 -req -days 3650 -in req.csr -signkey key.pem -out cert.pem # rm -f req.csr " Nobody remembers these commands, and leaving it and generate_cert out of the docs create an unnecessary obstacle. (The downside, of course, is that e.g. Windows users have no easy/out-of-the-box way to set up a Go SSL server.) |
mikioh
changed the title
crypto/tls/generate_cert.go is out of date in weekly
crypto/tls: generate_cert.go is out of date in weekly
Jan 14, 2015
FiloSottile
pushed a commit
to FiloSottile/go
that referenced
this issue
Oct 12, 2018
Fixes golang#2635. R=golang-dev, iant CC=golang-dev https://golang.org/cl/5512043
This issue was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The text was updated successfully, but these errors were encountered: