Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: use of request body in WASM Roundtripper panics #26349

Closed
johanbrandhorst opened this issue Jul 12, 2018 · 2 comments
Closed

net/http: use of request body in WASM Roundtripper panics #26349

johanbrandhorst opened this issue Jul 12, 2018 · 2 comments
Labels
arch-wasm WebAssembly issues FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@johanbrandhorst
Copy link
Member

What version of Go are you using (go version)?

tip

Does this issue reproduce with the latest release?

No, no WASM

What operating system and processor architecture are you using (go env)?

linux amd64

What did you do?

I sent a request with a body in a binary compiled for WASM.

What did you expect to see?

The request would be sent successfully.

What did you see instead?

When using a request body with the new http.RoundTripper implemented for WASM, the call to set the body on the JavaScript fetch object panics.

Notes

Initially reported by John Marshall in https://groups.google.com/forum/#!topic/golang-nuts/7ZIU-YKoDVw. The bug was introduced with bafe466, a simple case of missing a use of a slice in roundtrip_js.go: https://github.com/golang/go/blob/master/src/net/http/roundtrip_js.go#L63.

@johanbrandhorst johanbrandhorst changed the title net/http: use of request body in WASM Roundtripped panics net/http: use of request body in WASM Roundtripper panics Jul 12, 2018
@johanbrandhorst
Copy link
Member Author

I will submit a fix for this.

@gopherbot
Copy link

Change https://golang.org/cl/123537 mentions this issue: net/http: correct use of byte slice in js syscall

@agnivade agnivade added NeedsFix The path to resolution is known, but the work has not been done. arch-wasm WebAssembly issues labels Jul 12, 2018
@agnivade agnivade added this to the Go1.11 milestone Jul 12, 2018
@golang golang locked and limited conversation to collaborators Jul 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly issues FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

3 participants