New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
encoding/binary: Write is too slow #2634
Labels
Comments
I made a simple patch that does a type assertion if the slice is of basic type. This gets around reflecting on every element and gives a nice speedup I made a little benchmark included in the patch which just does a null write with some slices Before: BenchmarkWriteSlice1000Int32s 10000 122838 ns/op 32.56 MB/s After: BenchmarkWriteSlice1000Int32s 100000 24105 ns/op 165.93 MB/s Attachments:
|
Thanks! We don't use the bug tracker for code submissions or reviews, though. To contribute code, see: http://golang.org/doc/contribute.html |
Hi, If you are still interested in contributing this patch, please follow the procedure here http://golang.org/doc/contribute.html Cheers Dave Status changed to WaitingForReply. |
Hi DMorsing, if this patch still makes sense can you please hg mail it, otherwise close this issue. Owner changed to @DanielMorsing. Status changed to Started. |
I thought i made a CL out of the original patch and it got rejected because it was too ugly. In hindsight, I concur with that opinion. Can't find any mail evidence the rejection though, so maybe my memory is faulty. In any case, i'm releasing this bug so that other people can work on it. Owner changed to ---. Status changed to Accepted. |
This issue was closed by revision c0465d0. Status changed to Fixed. |
This issue was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The text was updated successfully, but these errors were encountered: