Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/http2: h2spec violation 6.10.1 #26324

Closed
fraenkel opened this issue Jul 11, 2018 · 2 comments
Closed

x/net/http2: h2spec violation 6.10.1 #26324

fraenkel opened this issue Jul 11, 2018 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Go1.12

Comments

@fraenkel
Copy link
Contributor 

$ ./h2spec -S -k -t -h 127.0.0.1 -p 8080 http2/6.10/1
Hypertext Transfer Protocol Version 2 (HTTP/2)
  6. Frame Definitions
    6.10. CONTINUATION
      × 1: Sends multiple CONTINUATION frames preceded by a HEADERS frame
        -> The endpoint must accept the frame.
           Expected: HEADERS Frame (stream_id:1)
             Actual: Connection closed
@fraenkel fraenkel mentioned this issue Jul 11, 2018
Closed
@ianlancetaylor ianlancetaylor added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 11, 2018
@ianlancetaylor ianlancetaylor added this to the Go1.12 milestone Jul 11, 2018
@fraenkel
Copy link
Contributor Author

This one is valid.
There is no handling of a HEADER (END_HEADERS=false) + CONTINUATION.

@fraenkel
Copy link
Contributor Author

My server had a MaxHeaderBytes set too low for this test. Once I increased it above the limit needed, the test passes.

@golang golang locked and limited conversation to collaborators Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Go1.12
Development

No branches or pull requests
3 participants
@fraenkel @ianlancetaylor @gopherbot