Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/http2: h2spec violation 6.1.2 #26323

Open
fraenkel opened this issue Jul 11, 2018 · 1 comment
Open

x/net/http2: h2spec violation 6.1.2 #26323

fraenkel opened this issue Jul 11, 2018 · 1 comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@fraenkel
Copy link
Contributor 

$ ./h2spec -S -k -t -h 127.0.0.1 -p 8080 http2/6.1/2

Hypertext Transfer Protocol Version 2 (HTTP/2)
  6. Frame Definitions
    6.1. DATA
      × 2: Sends a DATA frame on the stream that is not in "open" or "half-closed (local)" state
        -> The endpoint MUST respond with a stream error of type STREAM_CLOSED.
           Expected: GOAWAY Frame (Error Code: STREAM_CLOSED)
                     RST_STREAM Frame (Error Code: STREAM_CLOSED)
                     Connection closed
             Actual: DATA Frame (length:42, flags:0x01, stream_id:1)

This test also does not always fail so I believe its an h2spec issue. It fails more often if you run the 6.1 series, i.e. ./h2spec -S -k -t -h 127.0.0.1 -p 8080 http2/6.1
@fraenkel fraenkel mentioned this issue Jul 11, 2018
Closed
@ianlancetaylor ianlancetaylor added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 11, 2018
@ianlancetaylor ianlancetaylor added this to the Go1.12 milestone Jul 11, 2018
@fraenkel
Copy link
Contributor Author

Similar issue to all the others. There is a race between the response of the first and second request.

@andybons andybons modified the milestones: Go1.12, Go1.13 Feb 12, 2019
@andybons andybons modified the milestones: Go1.13, Go1.14 Jul 8, 2019
@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@rsc @andybons @fraenkel @ianlancetaylor