Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/godoc: firefox source highlighting issue #26316

Closed
bradfitz opened this issue Jul 10, 2018 · 4 comments
Closed

x/tools/godoc: firefox source highlighting issue #26316

bradfitz opened this issue Jul 10, 2018 · 4 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@bradfitz
Copy link
Contributor

Tracking bug on our side for fixing issue brought up in webcompat/web-bugs#17530

/cc @ysmolsky
@bradfitz bradfitz added the NeedsFix The path to resolution is known, but the work has not been done. label Jul 10, 2018
@bradfitz bradfitz added this to the Unreleased milestone Jul 10, 2018
@agnivade
Copy link
Contributor

Hmm .. isn't this a godoc issue ? The URL is from golang.org/src rather than play.golang.org.

@agnivade
Copy link
Contributor

Found it. Dup of #23500. This seems to be a bug with FF. We should re-open that bug and close this if we are to track this.

@bradfitz bradfitz changed the title x/playground: firefox source highlighting issue x/tools/godoc: firefox source highlighting issue Jul 10, 2018
@agnivade
Copy link
Contributor

agnivade commented Aug 27, 2018 •
edited

Closing this once since @kevinburke wants to take a crack at it and the original issue (#23500) was re-opened.

@gopherbot
Copy link

Change https://golang.org/cl/131716 mentions this issue: godoc: fix indenting on Firefox

gopherbot pushed a commit to golang/tools that referenced this issue Aug 30, 2018
@kevinburke @mvdan
godoc: fix indenting on Firefox
4bc20fc 
See comment in the patch for an explanation, Firefox (specifically
with the Menlo font) does not like tabs beginning in column 9, so we
start it in column 10.

Updates webcompat/web-bugs#17530
Fixes golang/go#26316
Fixes golang/go#23500

Change-Id: I4c96118b8c3b13ee1fd21ce85bd7c681e99a4b4f
Reviewed-on: https://go-review.googlesource.com/131716
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Andrew Bonventre <andybons@golang.org>
@golang golang locked and limited conversation to collaborators Aug 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@bradfitz @andybons @agnivade @gopherbot