You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks. I'm not sure how this went unnoticed for so long. The fix looks good, very straightforward. (Almost too easy... I recall struggling with the position information to ensure that it was possible to find "the" SSA instruction for a given source operator, which means you can't reuse that same position for implicit conversions, loads, etc. But those concerns don't seem to apply here.)
go/ssa doesn't store any position information for
<binop>=
operators (e.g.x &= 123
).IMO this is trivially fixable by passing a position to
(*builder).assignOp
, but I'm not sure if there's more to this that I've missed.Demonstrating the issue:
https://play.golang.org/p/hcDCHopxmYr
Potential fix:
/cc @alandonovan @griesemer does the proposed patch look sensible for a CL?
The text was updated successfully, but these errors were encountered: