Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/playground: use "go version" instead of runtime.Version #26291

Closed
FiloSottile opened this issue Jul 9, 2018 · 3 comments
Closed

x/playground: use "go version" instead of runtime.Version #26291

FiloSottile opened this issue Jul 9, 2018 · 3 comments
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@FiloSottile
Copy link
Contributor

In sandbox.go, cacheKey runs runtime.Version on the server to invalidate entries when the playground is upgraded. However, the compiler might get updated without the server version changing. Using go version would be correct in that case.
@gopherbot gopherbot added this to the Unreleased milestone Jul 9, 2018
@FiloSottile FiloSottile added help wanted NeedsFix The path to resolution is known, but the work has not been done. labels Jul 9, 2018
@gopherbot
Copy link

Change https://golang.org/cl/123915 mentions this issue: x/playground: use "go version" instead of runtime.Version as cache key

@ysmolski
Copy link
Member

I am sorry, but I fail to see the usefulness of this. We use only releases like 1.10, 1.10.2, etc in playground. And we do not use devel (tip) build of go there. go version does not contain anything different than runtime.Version:

$ go version
go version go1.11beta1 darwin/amd64

https://play.golang.org/p/Ztyu2FJaajl

cc: @andybons

@andybons
Copy link
Member

@ysmolsky is correct. The version specified at https://go.googlesource.com/playground/+/master/Dockerfile#11 is the same one used to build the playground binary and the nacl go command used to run code.

@dmitshur dmitshur removed NeedsFix The path to resolution is known, but the work has not been done. help wanted labels Oct 24, 2018
@golang golang locked and limited conversation to collaborators Oct 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@ysmolski @andybons @FiloSottile @dmitshur @gopherbot