-
Notifications
You must be signed in to change notification settings - Fork 18k
cmd/go: unhelpful go cache error when running in container as non-root user #26280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Milestone
Comments
I think it would be fine to disable the cache in that case. |
Change https://golang.org/cl/122487 mentions this issue: |
Per the Go 1.11 release notes:
I suspect that means that Docker users will need to set |
48 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (
go version
)?go version go1.10.3 linux/amd64
Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (
go env
)?GOOS="linux"
GOARCH="amd64"
What did you do?
Build any go program in a docker image as a user that doesn't exist in the image.
Although this sounds weird, it is specifically allowed in the docker run documentation
Any CI server following the principle of least privilege would be configured to run their containers in this way.
Assuming docker is installed, the following command will recreate the issue
More specifically, this is caused when $HOME is set to
/
which is what docker does in this situation.What did you expect to see?
What did you see instead?
Notes
This is effectively an iteration on #23638. Disabling the cache is probably still the correct thing to do, but in this case, the current error message is unnecessary and more confusing than it is helpful. You can see that confusion in docker-library/golang#225.
As I suggested in my comment on that issue, if go were to silently set GOCHACHE to "off" when
$HOME=='/'
then this confusion would be avoided. Go already does this when$HOME==''
, so I'm just proposing to extend that behavior to one more edge case.I'm happy to submit a PR that fixes this if you agree with the change.
The text was updated successfully, but these errors were encountered: