Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encoding/binary: document that PutVarint, PutUvarint assume buffer is big enough #2628

Closed
bradfitz opened this issue Dec 29, 2011 · 5 comments
Closed

encoding/binary: document that PutVarint, PutUvarint assume buffer is big enough #2628

bradfitz opened this issue Dec 29, 2011 · 5 comments
Labels
FrozenDueToAge
Milestone
Go1

Comments

@bradfitz
Copy link
Contributor 

... don't document behavior when the buf slice is too small.  (code reveals the answer
is that it panics)

It seems like things are elsewhere moving to AppendFoo signatures (norm, strconv). 
Should this too?

It should at least document its behavior, though.
@adg
Copy link
Contributor

adg commented Jan 4, 2012

Comment 1:

Labels changed: added priority-go1.

@robpike
Copy link
Contributor

robpike commented Jan 13, 2012

Comment 2:

Owner changed to builder@golang.org.

@bradfitz
Copy link
Contributor Author

Comment 3:

What's the preferred fix? Documentation or going to AppendFoo style, as done elsewhere?

@rsc
Copy link
Contributor

rsc commented Jan 20, 2012

Comment 4:

Let's just write documentation.

@bradfitz
Copy link
Contributor Author

Comment 6:

This issue was closed by revision 2c2c202.

Status changed to Fixed.

@rsc rsc added this to the Go1 milestone Apr 10, 2015
@rsc rsc removed the priority-go1 label Apr 10, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1
Development

No branches or pull requests
5 participants
@bradfitz @rsc @robpike @adg @gopherbot