Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/types: not enough arguments error message should be easier to skim #26249

Closed
rsc opened this issue Jul 6, 2018 · 2 comments
Closed

go/types: not enough arguments error message should be easier to skim #26249

rsc opened this issue Jul 6, 2018 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Backlog

Comments

@rsc
Copy link
Contributor

rsc commented Jul 6, 2018

Another difference between gc and go/types where I believe gc ends up more readable:

go test -short
# regexp [regexp.test]
./regexp.go:197:20: not enough arguments in call to progMachine
	have (*syntax.Prog, *onePassProg)
	want (*Regexp, *syntax.Prog, *onePassProg)
# regexp
./regexp.go:197:21: cannot use prog (variable of type *regexp/syntax.Prog) as *Regexp value in argument to progMachine
./regexp.go:197:27: cannot use onepass (variable of type *onePassProg) as *regexp/syntax.Prog value in argument to progMachine
./regexp.go:197:34: too few arguments in call to progMachine
vet: typecheck failures
@rsc rsc added this to the Go1.12 milestone Jul 6, 2018
@griesemer griesemer self-assigned this Dec 6, 2018
@griesemer griesemer added the NeedsFix The path to resolution is known, but the work has not been done. label Dec 6, 2018
@griesemer
Copy link
Contributor

Slightly more involved than what we want to do this late in the cycle. Moving to 1.13.

@griesemer griesemer modified the milestones: Go1.12, Go1.13 Dec 6, 2018
@griesemer griesemer modified the milestones: Go1.13, Go1.14 May 6, 2019
@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
@griesemer
Copy link
Contributor

This has been addressed in Go 1.18. Closing.

@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@rsc @griesemer @gopherbot