New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
time: clarify Ticker documentation #26220
Comments
Closing channels has no affect on the garbage collector, which doesn't care whether the channel is closed or not. What the doc means is that if |
@ianlancetaylor how does this sound?
|
@conspicuousClockwork Thanks. You need to say |
@ianlancetaylor Whoops, I must have erased part of it when I was thinking about how the text could be adjusted. I was trying to make as few additions as I could to clarify/phrase it in a different way but your suggestion seems better.
How is that? |
Seems OK to me. Perhaps "the read succeeding incorrectly." Want to send a pull request? |
Yup, I'll go ahead and open that. |
Change https://golang.org/cl/122715 mentions this issue: |
The documentation for
Stop()
states:Can the documentation clarify what
"to prevent a read from the channel succeeding incorrectly."
means.Should we close the channel ourself if we want to help the garbage collector?
The text was updated successfully, but these errors were encountered: