x/vgo: use submodule's latest commit in pseudo versions #26196
Labels
FrozenDueToAge
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
WaitingForInfo
Issue is not actionable because of missing required information, which needs to be provided.
Milestone
Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
n/a - this is a
git
and other VCS-related issue.What operating system and processor architecture are you using (
go env
)?What did you do?
At the time of writing, commit
5e591d073e90
is theHEAD
ofmaster
formyitcv.io
modules.gives output:
We can see the pseudo version for
myitcv.io/cmd/modpub
,v0.0.0-20180702093358-5e591d073e90
, corresponds to theHEAD
ofmaster
.But the latest commit within the
cmd/modpub
subdirectory (submodule) is actually 601ad1bf19:gives:
What did you expect to see?
It would be preferable to have the pseudo version for a submodule correspond to the commits relevant to that submodule. That way the pseudo version won't correspond to a commit that had nothing to do with that submodule (i.e. a commit that touched code elsewhere in the repo).
What did you see instead?
As above; the pseudo version is calculated from the repo-level commit log.
/cc @rsc @bcmills
The text was updated successfully, but these errors were encountered: