Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/vgo: unexpected list command behaviour #26176

Closed
bench opened this issue Jul 2, 2018 · 2 comments
Closed

x/vgo: unexpected list command behaviour #26176

bench opened this issue Jul 2, 2018 · 2 comments
Labels
FrozenDueToAge
Milestone
vgo

Comments

@bench
Copy link

bench commented Jul 2, 2018

What version of Go are you using (go version)?

go version go1.10.3 linux/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOROOT="/usr/local/go"
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build039741224=/tmp/go-build -gno-record-gcc-switches"

What did you do?

I followed the vgo tour available at [https://research.swtch.com/vgo-tour] with the latest version of vgo (installed via go get -u golang.org/x/vgo)

It appears that the command vgo list -m and vgo list -t rsc.io/sampler do not behave as expected.

What did you expect to see?

$ vgo list -m

$ vgo list -m  
MODULE                                    VERSION
github.com/you/hello  -
golang.org/x/text                         v0.3.0
rsc.io/quote                              v1.5.2
rsc.io/sampler                            v1.3.0

$ vgo list -t rsc.io/sampler

$ vgo list -t rsc.io/sampler
rsc.io/sampler
	v1.0.0
	v1.2.0
	v1.2.1
	v1.3.0
	v1.3.1
	v1.99.99

What did you see instead?

$ vgo list -m

vgo list -m  
github.com/you/hello

$ vgo list -t rsc.io/sampler

$ vgo list -t rsc.io/sampler
flag provided but not defined: -t
usage: list [-f format] [-json] [-m] [list flags] [build flags] [packages]
Run 'go help list' for details.

This used to work (tried with a past version, 6a94eb3 for instance)
@gopherbot gopherbot added this to the vgo milestone Jul 2, 2018
@bench bench changed the title x/vgo: unexpected list command behaviours x/vgo: unexpected list command behaviour Jul 2, 2018
@myitcv
Copy link
Member

myitcv commented Jul 2, 2018

@bench these commands have changed somewhat since Russ posted his articles on vgo.

Per https://go-review.googlesource.com/c/vgo/+/120198, vgo list -m is now vgo list -m all

Per #25656 (comment), vgo list -t appears to be currently broken, but that issue also captures a number of other changes that Russ has planned for vgo list.

I'll close this issue for now because I think both points are covered but please shout if that's not the case.

@myitcv myitcv closed this as completed Jul 2, 2018
@bench
Copy link
Author

bench commented Jul 2, 2018

@myitcv Thank you for replying fast. I will look forward Russ changes ! 👍

@golang golang locked and limited conversation to collaborators Jul 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
vgo
Development

No branches or pull requests
3 participants
@myitcv @bench @gopherbot