Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: go test reports compilation failures twice #26166

Closed
davecheney opened this issue Jul 1, 2018 · 2 comments
Closed

cmd/go: go test reports compilation failures twice #26166

davecheney opened this issue Jul 1, 2018 · 2 comments

Comments

@davecheney
Copy link
Contributor

davecheney commented Jul 1, 2018

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

% go version
go version devel +0dc814cd7f Sat Jun 30 01:04:30 2018 +0000 darwin/amd64

Does this issue reproduce with the latest release?

yes

What operating system and processor architecture are you using (go env)?

darwin/amd64

What did you do?

Daves-MacBook-Pro(~/src/github.com/heptio/contour/internal/dag) % go test
# github.com/heptio/contour/internal/dag [github.com/heptio/contour/internal/dag.test]
./dag_test.go:2359:18: undefined: sevicemap
./dag_test.go:2446:18: undefined: sevicemap
# github.com/heptio/contour/internal/dag
./dag_test.go:2359:18: undeclared name: sevicemap
./dag_test.go:2446:18: undeclared name: sevicemap
vet: typecheck failures
FAIL    github.com/heptio/contour/internal/dag [build failed]

What did you expect to see?

Daves-MacBook-Pro(~/src/github.com/heptio/contour/internal/dag) % go test
# github.com/heptio/contour/internal/dag [github.com/heptio/contour/internal/dag.test]
./dag_test.go:2359:18: undefined: sevicemap
./dag_test.go:2446:18: undefined: sevicemap
FAIL    github.com/heptio/contour/internal/dag [build failed]

What did you see instead?

go test runs vet over the code that failed to compile causing it to report the same errors again with a slightly different prefix.

@myitcv
Copy link
Member

myitcv commented Jul 1, 2018

Dup of #26125?

@davecheney
Copy link
Contributor Author

@myitcv whoops, sorry for the noise.

@golang golang locked and limited conversation to collaborators Jul 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants