New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net/http: k8s spdy TestUpgradeResponse broken in Go 1.11 #26161
Comments
Introduced by d88b137 "net/http, net/http/httptrace: make Transport support 1xx responses properly". (There have been a couple 1xx issues created recently; I haven't checked yet if they are related to this.) |
The server in the test returns only:
In particular, it does not satisfy the GET request.
So the test server is not following the spec and d88b137 is doing the right thing according to the spec, but causes breakage to things that rely on the old incorrect behavior. (If we don’t revert, some coordination between the libraries may be required. I'm going to look at the k8s test a bit more to see if I can get it to work with and without d88b137.) |
I think we can just treat 101 as a terminal status and fix this regression issue while also still fixing the original issue. |
Change https://golang.org/cl/121860 mentions this issue: |
I verified it passes again. Except now it fails with a vet error, but it passes with |
Trying "make test" in Kubernetes with Go 1.11, and ran into a problem in one test.
(All the other unit tests pass, so that's something!)
Note that the test doesn't use hardly any Kubernetes stuff (this is a very low-level package in the Kubernetes graph), so it can be run standalone on Mac etc., using plain go tools:
Using Go 1.10 everything is OK:
Using recent master (257d6c4, Thu Jun 28):
That test is sending an HTTP request header that includes:
The server is sending back a header with WriteHeader and then hijacks the connection.
The test expects the client to get back a 101 (switching protocols) response.
Instead it gets this error.
Any ideas?
The text was updated successfully, but these errors were encountered: