Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/review/git-codereview: add a flag to mail CLs with hashtags #26149

Closed
mvdan opened this issue Jun 29, 2018 · 2 comments
Closed

x/review/git-codereview: add a flag to mail CLs with hashtags #26149

mvdan opened this issue Jun 29, 2018 · 2 comments
Labels
FrozenDueToAge help wanted
Milestone
Unreleased

Comments

@mvdan
Copy link
Member

mvdan commented Jun 29, 2018 •
edited by robpike

For example, when mailing changes during a freeze, it can be useful to add the wait-release hashtag. It would be helpful to be able to do:

git-codereview -hashtag wait-release

To be consistent with other flags like -r, it should take a comma-separated list of strings.

The field can be passed onto Gerrit in a similar way to how the topic is passed: https://gerrit-review.googlesource.com/Documentation/user-upload.html#hashtag

Seems like a simple enough change, if someone wants to give it a go.
@gopherbot gopherbot added this to the Unreleased milestone Jun 29, 2018
@jespino
Copy link

jespino commented Jun 30, 2018

I would like to give it a try. :)

@gopherbot
Copy link

Change https://golang.org/cl/121798 mentions this issue: x/codereview: Add -hashtag flag to the codereview

@golang golang locked and limited conversation to collaborators Jul 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@jespino @mvdan @gopherbot