Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/gomote: improve edit/push/test cycle #26137

Closed
aclements opened this issue Jun 29, 2018 · 3 comments
Closed

x/build/cmd/gomote: improve edit/push/test cycle #26137

aclements opened this issue Jun 29, 2018 · 3 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Milestone

Comments

@aclements
Copy link
Member

When using a gomote, I often want a tight edit/push/test cycle, but the current behavior of gomote push makes this difficult. Specifically, because gomote push deletes all files from the remote tree that aren't in the local tree, I have to re-run a full make.bash every time I edit something and push, rather than just re-running the one test I care about. In general, deleting these files is clearly the right behavior, so I'm not sure what the answer is. Perhaps it shouldn't delete the build-generated files, such as go/src/runtime/internal/sys/zversion.go and maybe go/src/cmd/cgo/zdefaultcc.go and go/src/go/build/zcgo.go. Or perhaps we need to tweak the build process to be more friendly to cleaning the tree. The VERSION file may also be involved.

/cc @bradfitz

@gopherbot gopherbot added this to the Unreleased milestone Jun 29, 2018
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jun 29, 2018
@bradfitz
Copy link
Contributor

It used to ignore certain files to enable such a fast cycle. (that's how I used it) but I never updated it after the build cache changes. Should be an easy fix. Will do.

@ianlancetaylor
Copy link
Contributor

I always just run

gomote push TARGET
gomote run TARGET go/bin/go test package

and that works fine for me. What doesn't work for you? Is it possible that you need to sync your gomote sources past https://golang.org/cl/53070?

@aclements
Copy link
Member Author

You're quite right, Ian. I updated my gomote and this appears to work fine now. Sorry for the noise!

@golang golang locked and limited conversation to collaborators Jul 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Projects
None yet
Development

No branches or pull requests

4 participants