Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bytes: comparing long byte slices on s390x gives incorrect results [1.9 backport] #26118

Closed
gopherbot opened this issue Jun 28, 2018 · 2 comments
Closed

bytes: comparing long byte slices on s390x gives incorrect results [1.9 backport] #26118

gopherbot opened this issue Jun 28, 2018 · 2 comments
Labels
CherryPickCandidate Used during the release process for point releases FrozenDueToAge
Milestone
Go1.9.8

Comments

@gopherbot
Copy link

@bcmills requested issue #26114 to be considered for backport to the next 1.9 minor release.

@gopherbot, please consider backport to 1.10 and 1.9.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jun 28, 2018
@gopherbot gopherbot mentioned this issue Jun 28, 2018
Closed
@gopherbot gopherbot added this to the Go1.9.8 milestone Jun 28, 2018
@gopherbot
Copy link
Author

Change https://golang.org/cl/124137 mentions this issue: [release-branch.go1.9] bytes, strings: fix comparison of long byte slices on s390x

@gopherbot
Copy link
Author

Closed by merging f865b5f to release-branch.go1.9.

gopherbot pushed a commit that referenced this issue Jul 17, 2018
@wgo @ianlancetaylor
[release-branch.go1.9] bytes, strings: fix comparison of long byte sl…
f865b5f 
…ices on s390x

The existing implementation of bytes.Compare on s390x doesn't work properly for slices longer
than 256 elements. This change fixes that. Added tests for long strings and slices of bytes.

Fixes #26118

Change-Id: If6d8b68ee6dbcf99a24f867a1d3438b1f208954f
Reviewed-on: https://go-review.googlesource.com/121495
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-on: https://go-review.googlesource.com/124137
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@golang golang locked and limited conversation to collaborators Jul 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickCandidate Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.9.8
Development

No branches or pull requests
1 participant
@gopherbot