Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

text/template/parse: fix a comment around the assign operator #26112

Closed
wants to merge 1 commit into from
Closed

text/template/parse: fix a comment around the assign operator #26112

wants to merge 1 commit into from

Conversation

awbraunstein
Copy link
Contributor

@awbraunstein awbraunstein commented Jun 28, 2018 •
edited

Fix a comment that misrepresented the Assign operator (=).

Rename: colon-equals -> equals.

@awbraunstein
Fix a comment in lex.go
aec0bf5 
Fix a comment that misrepresented the Assign opperator (=)

colon-equals -> equals
@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Jun 28, 2018
@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/121416.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Jun 28, 2018
@awbraunstein @bradfitz
text/template/parse: fix a comment around the assign operator
578b961 
Fix a comment that misrepresented the Assign operator (=).

Rename: colon-equals -> equals.

Change-Id: I405b8acfb0bcd1b176a91a95f9bfb61a4e85815f
GitHub-Last-Rev: aec0bf5
GitHub-Pull-Request: #26112
Reviewed-on: https://go-review.googlesource.com/121416
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot
Copy link

Message from Brad Fitzpatrick:

Patch Set 1: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/121416.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

This PR is being closed because golang.org/cl/121416 has been merged.

@gopherbot gopherbot closed this Jun 28, 2018
@awbraunstein awbraunstein deleted the patch-1 branch February 15, 2019 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@awbraunstein @gopherbot @googlebot