Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: use wrappers for op= map operations #26059

Open
randall77 opened this issue Jun 26, 2018 · 5 comments
Open

runtime: use wrappers for op= map operations #26059

randall77 opened this issue Jun 26, 2018 · 5 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Performance
Milestone
Backlog

Comments

@randall77
Copy link
Contributor

CL 120255 made mapdelete zero the value all the time, to make sure op= map operations work correctly.
Probably we should do wrapper functions for op= operations so we don't need to zero during all map deletes.

@vkuzmin-uber
@martisch
@randall77 randall77 added this to the Go1.12 milestone Jun 26, 2018
@FiloSottile FiloSottile added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 26, 2018
@martisch martisch mentioned this issue Sep 18, 2018
Closed
@vkuzmin-uber
Copy link
Contributor

Looking on it.

@randall77 randall77 assigned randall77 and unassigned martisch and randall77 Sep 19, 2018
@randall77
Copy link
Contributor Author

@vkuzmin-uber : For some reason I can't assign you to this issue. I tried and failed.

@dominikh
Copy link
Member

@randall77 that's what the go-assignees role exists for. Only members of some role in the organization can be assigned issues.

@gopherbot
Copy link

Change https://golang.org/cl/139101 mentions this issue: runtime: use wrappers for op= map operations

@vkuzmin-uber
Copy link
Contributor

Just published change that works. I consider this as a proof of concept and feel free to suggest another design. About "go-assignees role" - please let me know if I can do something to get it.

@aclements aclements modified the milestones: Go1.12, Go1.13 Jan 8, 2019
@randall77 randall77 modified the milestones: Go1.13, Go1.14 Jun 3, 2019
@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Performance
Projects
Go Compiler / Runtime
Status: Triage Backlog
Milestone
Backlog
Development

No branches or pull requests
8 participants
@dominikh @rsc @martisch @FiloSottile @aclements @randall77 @gopherbot @vkuzmin-uber