-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build: add js/wasm trybot #26015
Comments
Change https://golang.org/cl/120575 mentions this issue: |
After the std tests, most of the rest of the tests aren't applicable to js/wasm. (anything with -cpu=>1, cgo, etc) Skip them all for now. We can incrementally re-enable them over time as the js/wasm port is fleshed out. But let's get the builder column black again so we can enable trybots and keep it black. Updates #26014 Updates #26015 Updates #18892 Change-Id: I8992ed3888f598fa42273ce8646a32d62ce45b1d Reviewed-on: https://go-review.googlesource.com/120575 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Andrew Bonventre <andybons@golang.org>
@bradfitz - I'm not so familiar with how the builders work, but would it be possible to have Node, Chrome and Firefox installed on the image/setup where the Headless tests via Chrome and Firefox at least would likely be a big help. |
@myitcv, let's keep this bug about just TryBot-ifying the existing Node-based wasm builder. Creating a new Chrome and/or Firebox-based builder is possible I'm sure, but let's track that elsewhere. |
Change https://golang.org/cl/120775 mentions this issue: |
This is deployed. I'll watch its performance. |
Add either a just-compile or a sharded testing js/wasm trybot.
Would've prevented #26014.
/cc @ianlancetaylor @neelance @andybons @bcmills @FiloSottile
The text was updated successfully, but these errors were encountered: