New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/vgo: Doesn't seem to be finding tags correctly #26003
Comments
sqlboiler needs a go.mod file spevifiying a v3 module path. Add that and you should be golden. |
Hey @kardianos, thanks for the reply. I'm not sure I understand the suggestion though. I've read about semantic import versioning and Russ's comments about the differences between branches/tags/directories for the purpose of using it. My understanding was that they should be considered equal, so given that, is there still a reason to have to include a I was sort of under the impression that this tool was going to work with code that didn't know I really expected a properly versioned repository that has it's only module at the repository root to "just work". |
Ugh. I guess I didn't read close enough. Answered my own question I suppose. The reasoning is unfortunately kind of sound too so I can't even nitpick it too much. Though I think it's definitely a very bad decision to have done it this way. How am I supposed to support non-vgo at the same time? If I change all these import paths to use /v3, it'll break my existing users that don't use vgo since that isn't an import path that can ever possibly exist. |
There are point releases for 1.10 and 1.9 that allow working with vX paths. For the this transition, some packages will need to continue to use the v0-rev notation to get versions larger then v1. What you discovered has already been addressed. |
What version of Go are you using (
go version
)?go version go1.10.2 linux/amd64 vgo:2018-02-20.1
Does this issue reproduce with the latest release?
Yes (of vgo, haven't updated Go if there's a new release of that).
What operating system and processor architecture are you using (
go env
)?Linux amd64.
What did you do?
Tried several different ways to use v3.0.0-rc5 of my library: https://github.com/volatiletech/sqlboiler/tree/v3.0.0-rc5.
I imported:
And then used a
go.mod
that specifiedv3.0.0-rc5
.I also tried to list the tags available in that repo:
What did you expect to see?
I expected to see the tag v3.0.0-rc5 in the go.mod file (and I expected it to stay when I manually coerced it to the correct thing).
I expected to see it correctly list the v1, v2, and v3 tags that exist in that repository, here's some of the tags
that I expected to see:
What did you see instead?
I do not see a tag (though I do see the correct commit) in the vgo go.mod file:
I do not see the correct tags listed in the repository:
The text was updated successfully, but these errors were encountered: