Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: case mismatch on Windows #25992

Closed
millergarym opened this issue Jun 21, 2018 · 3 comments
Closed

cmd/go: case mismatch on Windows #25992

millergarym opened this issue Jun 21, 2018 · 3 comments
Labels
FrozenDueToAge modules NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Milestone

Comments

@millergarym
Copy link

What version of Go are you using (go version)?

go 1.10.3
vgo commit c07973ea63c163b154225425f63290d022df8650

What operating system and processor architecture are you using (go env)?

windows

What did you do?

example.go

package vgot // import "some.package/p/vgot"

import (
	_ "github.com/docker/docker"
	_ "github.com/sirupsen/logrus"
)

go.mod

module some.package/p/vgot

vgo build

What did you see instead?

			return nil, fmt.Errorf("downloaded %q and got module %q", mod.Path, mpath)
@gopherbot gopherbot added this to the vgo milestone Jun 21, 2018
@bcmills
Copy link
Contributor

bcmills commented Jun 21, 2018

Closely related to #25878 and https://golang.org/cl/118738 (CC: @bradfitz @alexbrainman).

@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 21, 2018
@rsc
Copy link
Contributor

rsc commented Jul 6, 2018

I think what's going on here is that the (old) docker you got
has its own import of "github.com/Sirupsen/logrus",
and then your code has an import of "github.com/sirupsen/logrus",
and the two collide in the GOPATH/src/mod/cache/download tree.

Unfortunately, the layout of that tree was chosen to match the
HTTP REST API file tree, so it's not a purely internal detail we can
just change (using "_sirupsen" for "Sirupsen" for example).

@rsc rsc added NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jul 6, 2018
@rsc rsc modified the milestones: vgo, Go1.11 Jul 12, 2018
@rsc rsc added the modules label Jul 12, 2018
@rsc rsc changed the title x/vgo: case mismatch on Windows cmd/go: case mismatch on Windows Jul 12, 2018
@gopherbot
Copy link

Change https://golang.org/cl/124379 mentions this issue: cmd/go/internal/modfetch: do not rely on file system for case sensitivity

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge modules NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Projects
None yet
Development

No branches or pull requests

4 participants